re-export torch.optim._multi_tensor in torch/__init__.py #129095
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129095
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 4b6c259 with merge base d8db074 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D58792889 |
fbgheith
added a commit
to fbgheith/pytorch
that referenced
this pull request
Jun 19, 2024
) Summary: Pull Request resolved: pytorch#129095 - PR pytorch#127703 introduced a circular dependency `torch/optim/__init__.py` imports `torch.optim._multi_tensor` and `torch.optim._multi_tensor/_init__.py` imports `torch.optim` This seemed to work fine (green signals everywhere) but caused some internal test failures after it landed; an infinite recursion during import. - PR pytorch#128875 attempted to fix this by removing the import from `torch/optim/__init__.py`. This seemed to work fine: green signals everywhere and the failing tests started passing but a smaller number of tests started failing; unable to import `torch.optim._multi_tensor` - This diff re-introduces the import but after `torch.optim` is fully initialized Test Plan: CI signals Differential Revision: D58792889
fbgheith
force-pushed
the
export-D58792889
branch
from
d4fe3fc
to
aaaff5f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58792889 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D58792889 |
fbgheith
force-pushed
the
export-D58792889
branch
from
aaaff5f
to
fbcd85c
Compare
fbgheith
added a commit
to fbgheith/pytorch
that referenced
this pull request
Jun 20, 2024
) Summary: Pull Request resolved: pytorch#129095 - PR pytorch#127703 introduced a circular dependency `torch/optim/__init__.py` imports `torch.optim._multi_tensor` and `torch.optim._multi_tensor/_init__.py` imports `torch.optim` This seemed to work fine (green signals everywhere) but caused some internal test failures after it landed; an infinite recursion during import. - PR pytorch#128875 attempted to fix this by removing the import from `torch/optim/__init__.py`. This seemed to work fine: green signals everywhere and the failing tests started passing but a smaller number of tests started failing; unable to import `torch.optim._multi_tensor` - This diff re-introduces the import but after `torch.optim` is fully initialized Test Plan: CI signals Differential Revision: D58792889
) Summary: Pull Request resolved: pytorch#129095 - PR pytorch#127703 introduced a circular dependency `torch/optim/__init__.py` imports `torch.optim._multi_tensor` and `torch.optim._multi_tensor/_init__.py` imports `torch.optim` This seemed to work fine (green signals everywhere) but caused some internal test failures after it landed; an infinite recursion during import. - PR pytorch#128875 attempted to fix this by removing the import from `torch/optim/__init__.py`. This seemed to work fine: green signals everywhere and the failing tests started passing but a smaller number of tests started failing; unable to import `torch.optim._multi_tensor` - This diff re-introduces the import but after `torch.optim` is fully initialized Test Plan: CI signals Differential Revision: D58792889
|
This pull request was exported from Phabricator. Differential Revision: D58792889 |
fbgheith
force-pushed
the
export-D58792889
branch
from
fbcd85c
to
4b6c259
Compare
XuehaiPan
reviewed
Jun 21, 2024
| @@ -1987,6 +1987,7 @@ def _assert(condition, message): | |||
| utils as utils, | |||
| xpu as xpu, | |||
| ) | |||
| import torch.optim._multi_tensor # usort: skip | |||
There was a problem hiding this comment.
May need to add a comment here:
Suggested change
| import torch.optim._multi_tensor # usort: skip | |
| # needs to be before import torch.optim as optim to avoid circular dependencies | |
| import torch.optim._multi_tensor # usort: skip |
XuehaiPan
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
PR [BE][Easy] export explicitly imported public submodules #127703 introduced a circular dependency
torch/optim/__init__.pyimportstorch.optim._multi_tensorandtorch.optim._multi_tensor/_init__.pyimportstorch.optimThis seemed to work fine (green signals everywhere) but caused some internal test failures after it landed; an infinite recursion during import.
PR Remove circular import #128875 attempted to fix this by removing the import from
torch/optim/__init__.py.This seemed to work fine: green signals everywhere and the failing tests started passing but a smaller number of tests started failing; unable to import
torch.optim._multi_tensortorch.optimis fully initializedTest Plan: CI signals
Differential Revision: D58792889