Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dynamic rollout for pull workflow #129243

Closed
wants to merge 3 commits into from

Conversation

ZainRizvi
Copy link
Contributor

@ZainRizvi ZainRizvi commented Jun 21, 2024

Enables dynamic migration of jobs to the LF AWS account for the pull workflow. For now, it leaves out a few jobs that need a bit more testing: Namely Windows and Android runners.

The new runners are only given to people specified in this issue:
pytorch/test-infra#5132

Note: The non-pull jobs updated are the ones that have are synced to jobs in pull.yml (via sync-tag) and thus have to be updated whenever their corresponding pull.yml jobs are edited

Based on #128597

Copy link

pytorch-bot bot commented Jun 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129243

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit bf7f6c7 with merge base 920ebcc (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 21, 2024
@ZainRizvi ZainRizvi marked this pull request as ready for review June 21, 2024 16:40
@ZainRizvi ZainRizvi requested a review from a team as a code owner June 21, 2024 16:40
@ZainRizvi ZainRizvi added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 21, 2024
@ZainRizvi
Copy link
Contributor Author

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Enables dynamic migration of jobs to the LF AWS account for the pull workflow.  For now, it leaves out a few jobs that need a bit more testing: Namely Windows and Android runners.
@pytorchmergebot
Copy link
Collaborator

Successfully rebased zainr/ali-dynamic-rollout onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout zainr/ali-dynamic-rollout && git pull --rebase)

Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with @ZainRizvi that this would work without the need to do a rebase on people PR

@ZainRizvi
Copy link
Contributor Author

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: pull / linux-jammy-py3.8-gcc11 / test (distributed, 1, 2, linux.2xlarge), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-14)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@@ -35,22 +35,31 @@ jobs:
id-token: write
contents: read

get-label-type:
name: get-label-type
uses: ./.github/workflows/_runner-determinator.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit weird to run _runner-determinator on linux-4xlarge, while lots of the jobs it's gating will be running on linux-2xlarge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants