-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dynamic rollout for pull workflow #129243
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129243
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit bf7f6c7 with merge base 920ebcc ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchmergebot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Enables dynamic migration of jobs to the LF AWS account for the pull workflow. For now, it leaves out a few jobs that need a bit more testing: Namely Windows and Android runners.
Successfully rebased |
9f21e32
to
bf7f6c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with @ZainRizvi that this would work without the need to do a rebase on people PR
@pytorchmergebot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: pull / linux-jammy-py3.8-gcc11 / test (distributed, 1, 2, linux.2xlarge), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-14) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@@ -35,22 +35,31 @@ jobs: | |||
id-token: write | |||
contents: read | |||
|
|||
get-label-type: | |||
name: get-label-type | |||
uses: ./.github/workflows/_runner-determinator.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels a bit weird to run _runner-determinator on linux-4xlarge, while lots of the jobs it's gating will be running on linux-2xlarge
Enables dynamic migration of jobs to the LF AWS account for the pull workflow. For now, it leaves out a few jobs that need a bit more testing: Namely Windows and Android runners.
The new runners are only given to people specified in this issue:
pytorch/test-infra#5132
Note: The non-pull jobs updated are the ones that have are synced to jobs in pull.yml (via
sync-tag
) and thus have to be updated whenever their corresponding pull.yml jobs are editedBased on #128597