New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tensor stride #129297

Closed

shengfukevin wants to merge 1 commit into pytorch:main from shengfukevin:export-D58900476

Contributor

shengfukevin commented Jun 22, 2024

Summary:
X-link: facebookresearch/param#126

Support tensor stride for execution trace.

Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace

Differential Revision: D58900476

shengfukevin requested a review from aaronenyeshi as a code owner

June 22, 2024 02:15

pytorch-bot bot commented Jun 22, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129297

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit e9cf9c1 with merge base 22c809a ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh) (trunk failure)
test_jit.py::TestScript::test_function_overloading_isinstance
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 2, 3, linux.2xlarge) (gh) (trunk failure)
test_jit.py::TestScript::test_function_overloading_isinstance

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Jun 22, 2024

This pull request was exported from Phabricator. Differential Revision: D58900476

facebook-github-bot added the fb-exported label

sanrise approved these changes

View reviewed changes

Contributor

sanrise left a comment

LGTM.

pytorch-bot bot added the ciflow/trunk label

shengfukevin added a commit to shengfukevin/param that referenced this pull request


          Support tensor stride (facebookresearch#126)

e3da5f3

Summary:
X-link: pytorch/pytorch#129297

Pull Request resolved: facebookresearch#126

Support tensor stride for execution trace.

Reviewed By: sanrise

Differential Revision: D58900476

shengfukevin force-pushed the export-D58900476 branch from 7d121ef to 5c78e18 Compare

July 8, 2024 17:10

shengfukevin requested a review from sraikund16 as a code owner

July 8, 2024 17:10

Contributor

facebook-github-bot commented Jul 8, 2024

This pull request was exported from Phabricator. Differential Revision: D58900476

Contributor

facebook-github-bot commented Jul 8, 2024

This pull request was exported from Phabricator. Differential Revision: D58900476

shengfukevin force-pushed the export-D58900476 branch from 5c78e18 to 72159fe Compare

July 8, 2024 17:17

shengfukevin added a commit to shengfukevin/param that referenced this pull request


          Support tensor stride (facebookresearch#126)

d5548be

Summary:
X-link: pytorch/pytorch#129297

Pull Request resolved: facebookresearch#126

Support tensor stride for execution trace.

Reviewed By: sanrise

Differential Revision: D58900476

shengfukevin added a commit to shengfukevin/pytorch that referenced this pull request


          Support tensor stride (pytorch#129297)

eaa2eab

Summary:
Pull Request resolved: pytorch#129297

X-link: facebookresearch/param#126

Support tensor stride for execution trace.

Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace

Reviewed By: sanrise

Differential Revision: D58900476

shengfukevin force-pushed the export-D58900476 branch from 72159fe to eaa2eab Compare

July 8, 2024 17:54

Contributor

facebook-github-bot commented Jul 8, 2024

This pull request was exported from Phabricator. Differential Revision: D58900476

1 similar comment

Contributor

facebook-github-bot commented Jul 8, 2024

This pull request was exported from Phabricator. Differential Revision: D58900476

shengfukevin force-pushed the export-D58900476 branch from eaa2eab to a3dc4ef Compare

July 8, 2024 18:21

shengfukevin added a commit to shengfukevin/pytorch that referenced this pull request


          Support tensor stride (pytorch#129297)

3e27176

Summary:
Pull Request resolved: pytorch#129297

X-link: facebookresearch/param#126

Support tensor stride for execution trace.

Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace

Reviewed By: sanrise

Differential Revision: D58900476

Contributor

facebook-github-bot commented Jul 8, 2024

This pull request was exported from Phabricator. Differential Revision: D58900476

shengfukevin force-pushed the export-D58900476 branch from a3dc4ef to 3e27176 Compare

July 8, 2024 18:27

Contributor

facebook-github-bot commented Jul 8, 2024

This pull request was exported from Phabricator. Differential Revision: D58900476

shengfukevin force-pushed the export-D58900476 branch from 3e27176 to 7c72f44 Compare

July 8, 2024 18:34

Contributor

facebook-github-bot commented Jul 8, 2024

This pull request was exported from Phabricator. Differential Revision: D58900476

shengfukevin force-pushed the export-D58900476 branch from 7c72f44 to a174386 Compare

July 8, 2024 19:21


          Support tensor stride (pytorch#129297)

e9cf9c1

Summary:
Pull Request resolved: pytorch#129297

X-link: facebookresearch/param#126

Support tensor stride for execution trace.

Test Plan: buck2 test mode/opt caffe2/test:test_profiler_cuda profiler.test_execution_trace.TestExecutionTrace

Reviewed By: sanrise

Differential Revision: D58900476

Contributor

facebook-github-bot commented Jul 8, 2024

This pull request was exported from Phabricator. Differential Revision: D58900476

shengfukevin force-pushed the export-D58900476 branch from a174386 to e9cf9c1 Compare

July 8, 2024 19:28

facebook-github-bot pushed a commit to facebookresearch/param that referenced this pull request


          Support tensor stride (#126)

Summary:
X-link: pytorch/pytorch#129297

Pull Request resolved: #126

Support tensor stride for execution trace.

Reviewed By: sanrise

Differential Revision: D58900476

fbshipit-source-id: bb6c30a2ba1a31930aa5f6fc2a4aea5671c20f48

Contributor

facebook-github-bot commented Jul 9, 2024

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Jul 9, 2024

Merge failed

Reason: Approvers from one of the following sets are needed:

superuser (pytorch/metamates)
Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

pytorchmergebot removed the merging label

izaitsevfb approved these changes

View reviewed changes

Contributor

izaitsevfb commented Jul 9, 2024

@pytorchbot merge

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Jul 9, 2024

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

pytorchmergebot removed the merging label

Contributor Author

shengfukevin commented Jul 9, 2024

topic: not user facing

Contributor Author

shengfukevin commented Jul 9, 2024

@pytorchbot merge

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Jul 9, 2024

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

pytorchmergebot removed the merging label

shengfukevin added the topic: not user facing label

Contributor Author

shengfukevin commented Jul 9, 2024

@pytorchbot merge

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Jul 9, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot closed this in

31df1d2

pytorchmergebot added Merged and removed merging labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sanrise sanrise approved these changes

izaitsevfb izaitsevfb approved these changes

aaronenyeshi Awaiting requested review from aaronenyeshi aaronenyeshi is a code owner

sraikund16 Awaiting requested review from sraikund16 sraikund16 is a code owner