Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support XPU ABI neutral build #130110

Open
wants to merge 14 commits into
base: gh/guangyey/48/base
Choose a base branch
from
Open

[WIP] Support XPU ABI neutral build #130110

wants to merge 14 commits into from
+28 −18

Conversation

guangyey
Copy link
Collaborator

@guangyey guangyey commented Jul 4, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130110

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 28 Pending, 3 Unrelated Failures

As of commit 330276d with merge base 3e48d92 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guangyey added a commit that referenced this pull request Jul 4, 2024
@guangyey
Support XPU ABI neutral build
6e8144f 
ghstack-source-id: 696605e4cb2941a553838d3c39b211438a4c7afc
Pull Request resolved: #130110
@guangyey guangyey changed the title Support XPU ABI neutral build [WIP] Support XPU ABI neutral build Jul 4, 2024
@guangyey guangyey added ciflow/xpu Run XPU CI tasks release notes: xpu release notes category labels Jul 4, 2024
guangyey added a commit that referenced this pull request Jul 4, 2024
@guangyey
Support XPU ABI neutral build
f72a8d3 
ghstack-source-id: db73b1b7b5ebaede154063eeea94d6bf179647d5
Pull Request resolved: #130110
@guangyey guangyey mentioned this pull request Jul 4, 2024
Draft
@pytorch-bot pytorch-bot bot added ciflow/linux-aarch64 linux aarch64 CI workflow module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration labels Jul 4, 2024
guangyey added a commit that referenced this pull request Jul 4, 2024
@guangyey
Support XPU ABI neutral build
1a97278 
ghstack-source-id: 802f4f39410ea1cd02cdc2f84e75ff7b1f4b499c
Pull Request resolved: #130110
guangyey added a commit that referenced this pull request Jul 5, 2024
@guangyey
Support XPU ABI neutral build
dace892 
ghstack-source-id: 95e506ea15a87f4c6504ba5c57740a7646645bc2
Pull Request resolved: #130110
guangyey added a commit that referenced this pull request Jul 5, 2024
@guangyey
Support XPU ABI neutral build
311eef2 
ghstack-source-id: 843d32a0f0045d2ed17c7a148e93300883af47ba
Pull Request resolved: #130110
@guangyey
Update on "[WIP] Support XPU ABI neutral build"
4987f77 
cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
@guangyey
Update on "[WIP] Support XPU ABI neutral build"
37b3fde 
cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
EikanWang
EikanWang reviewed Jul 6, 2024
View reviewed changes
cmake/Dependencies.cmake Outdated
Comment on lines 93 to 95
else()
# Workaround about XPU ABI neutral build
string(APPEND CMAKE_CXX_FLAGS " -D__INTEL_PREVIEW_BREAKING_CHANGES")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get commitment from the compiler team.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you, please, also get more details into PR description? what "ABI neutral build" means? what is sycl-preview library? will ever changes from preview available in stock?

guangyey added a commit that referenced this pull request Jul 9, 2024
@guangyey
Support XPU ABI neutral build
ddcd94c 
ghstack-source-id: 0aca65603686911284558dfeb90748ab4680d5ca
Pull Request resolved: #130110
guangyey added a commit that referenced this pull request Jul 9, 2024
@guangyey
Support XPU ABI neutral build
786969b 
ghstack-source-id: dd6947030ee25d473c22f159ec4a423665937ef7
Pull Request resolved: #130110
guangyey added a commit that referenced this pull request Jul 9, 2024
@guangyey
Support XPU ABI neutral build
d4a713c 
ghstack-source-id: db3a05425f6f01a0df7ba758d7ff79caf06ff77d
Pull Request resolved: #130110
guangyey added a commit that referenced this pull request Jul 9, 2024
@guangyey
Support XPU ABI neutral build
a2f1657 
ghstack-source-id: 47546a142757d517ac92a33b8ff7871a5d91c5c9
Pull Request resolved: #130110
guangyey added a commit that referenced this pull request Jul 9, 2024
@guangyey
Support XPU ABI neutral build
a7a1a4f 
ghstack-source-id: 037978eb044a90fa0c1101ed82c457e334585b67
Pull Request resolved: #130110
@guangyey guangyey removed the module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration label Jul 9, 2024
@pytorch-bot pytorch-bot bot added the module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration label Jul 9, 2024
guangyey added a commit that referenced this pull request Jul 9, 2024
@guangyey
Support XPU ABI neutral build
f4e4302 
ghstack-source-id: 315387a64459f9f24159e46d728ab9495487c9c8
Pull Request resolved: #130110
guangyey added a commit that referenced this pull request Jul 9, 2024
@guangyey
Support XPU ABI neutral build
00e5cbf 
ghstack-source-id: dcf8872650646b593ac084c5840ed69ff58317fd
Pull Request resolved: #130110
guangyey added a commit that referenced this pull request Jul 9, 2024
@guangyey
Support XPU ABI neutral build
b412bd2 
ghstack-source-id: ae6420ebe1323a2c50cf31bb16f9e5b0f3541ac7
Pull Request resolved: #130110
@guangyey
Update on "[WIP] Support XPU ABI neutral build"
72612b7 
cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
@guangyey
Update on "[WIP] Support XPU ABI neutral build"
1617b84 
cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
@guangyey
Update on "[WIP] Support XPU ABI neutral build"
42ded32 
cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
@guangyey
Update on "[WIP] Support XPU ABI neutral build"
fb6325e 
cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
@guangyey
Update on "[WIP] Support XPU ABI neutral build"
98ab407 
cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
@guangyey
Update on "[WIP] Support XPU ABI neutral build"
245a572 
cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
@guangyey
Update on "[WIP] Support XPU ABI neutral build"
ce8136d 
cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
@guangyey
Update on "[WIP] Support XPU ABI neutral build"
316a703 
cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
@guangyey
Update on "[WIP] Support XPU ABI neutral build"
330276d 
cc gujinghui PenghuiCheng XiaobingSuper jianyuh jgong5 mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvrogozh dvrogozh dvrogozh left review comments

@EikanWang EikanWang EikanWang left review comments

@gujinghui gujinghui Awaiting requested review from gujinghui gujinghui is a code owner

Assignees
No one assigned
Labels
ciflow/linux-aarch64 linux aarch64 CI workflow ciflow/xpu Run XPU CI tasks module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration open source release notes: xpu release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guangyey @dvrogozh @EikanWang @pytorchbot