Make mean function work across multiple dimensions.
#14252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
umanwizard
force-pushed
the
mean_multi_dim
branch
from
05ebfc9
to
27eb37d
Compare
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
apaszke
suggested changes
Nov 26, 2018
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
colesbury
approved these changes
Nov 27, 2018
colesbury
reviewed
Nov 27, 2018
| // Additionally: | ||
| // - First input should be the only tensor input | ||
| // - has a bool keepdim argument | ||
| static const register_formula_for multidim_reduce_ops { |
There was a problem hiding this comment.
@zou3519 are you familiar with this file? Can you take a look at this change?
apaszke
approved these changes
Nov 28, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 28, 2018
Summary: Multi-dimensional `sum` is already implemented, and it's trivial to implement `mean` in terms of `sum`, so just do it. Bonus: Fix incomplete language in the `torch.sum` documentation which doesn't take into account multiple dimensions when describing `unsqueeze` (at the same time as introducing similar language in `torch.mean`). Pull Request resolved: pytorch/pytorch#14252 Differential Revision: D13161157 Pulled By: umanwizard fbshipit-source-id: c45da692ba83c0ec80815200c5543302128da75c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-dimensional
sumis already implemented, and it's trivial to implementmeanin terms ofsum, so just do it.Bonus: Fix incomplete language in the
torch.sumdocumentation which doesn't take into account multiple dimensions when describingunsqueeze(at the same time as introducing similar language intorch.mean).