In README.md CMAKE_PREFIX_PATH should be CONDA_PREFIX when using an conda virtual environment #15548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
approved these changes
Dec 26, 2018
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current README.md,
CMAKE_PREFIX_PATHis set to conda root even when you have activated an virtual environment. When an conda virtualenv is activated, packages are installed inCONDA_PREFIX, not conda root. I thinkCMAKE_PREFIX_PATHshould also be set toCONDA_PREFIXin this case. I think some build issues can be solved with the new instruction. Maybe something like #14954.@soumith,
When I made PR #15335 I was confused and made a wrong point. I think this PR could be the real solution.