Add stack & cat support for CPU Half #16389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchanan
approved these changes
Jan 29, 2019
| # inf check if allow_inf=True | ||
| if allow_inf: | ||
| inf_mask = torch.isinf(a) | ||
| self.assertTrue(torch.equal(inf_mask, torch.isinf(b)), message) |
There was a problem hiding this comment.
the old code did this too, but won't this allow +inf and -inf to be equal?
There was a problem hiding this comment.
You are right. I can submit a PR later to test CI and see if this is an easy fix, but I prefer to merge this first :)
There was a problem hiding this comment.
@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jan 29, 2019
Summary: Fixes pytorch/pytorch#6968 Needed for #14705 Pull Request resolved: pytorch/pytorch#16389 Differential Revision: D13861446 Pulled By: gchanan fbshipit-source-id: 7b8700b95aaf252d9669693dbddccb2302e58409
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 12, 2019
Summary: gchanan pointed out in #16389 that `allow_inf` is treating `-inf` and `inf` as equal. This fixes it. Also fixing #16448 since it's near and 2.1 has released. Pull Request resolved: #16959 Differential Revision: D14025297 Pulled By: gchanan fbshipit-source-id: 95348309492e7ab65aa4d7aabb5a1800de66c5d6
|
I'm confused - why is this closed? |
|
@TimZaman it got merged into master. our bot closes a PR that got merged into master instead of a "github merge" purple color |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6968
Needed for #14705