deprecated function based API #18444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D14467495 Differential Version: 75440815
Differential Revision: D14467497 Differential Version: 7544081
Differential Revision: D14467494 Differential Version: 75440810
Differential Revision: D14467495 Differential Version: 75517723
Differential Revision: D14467497 Differential Version: 75517725
Differential Revision: D14467494 Differential Version: 75517722
Differential Revision: D14467495 Differential Version: 75582406
Differential Revision: D14467497 Differential Version: 75582411
Differential Revision: D14467494 Differential Version: 75582407
Differential Revision: D14467497 Differential Version: 75619769
Differential Revision: D14467494 Differential Version: 75619771
Differential Revision: D14491454 Differential Version: 7566766
Differential Revision: D14467494 Differential Version: 75926298
Differential Revision: D14491454 Differential Version: 75960874
Differential Revision: D14512187 Differential Version: 75960910
Differential Revision: D14512189 Differential Version: 7596091
Differential Revision: D14513420 Differential Version: 75960914
Differential Revision: D14514231 Differential Version: 75960913
Differential Revision: D14514239 Differential Version: 75960916
Differential Revision: D14467494 Differential Version: 75964015
Differential Revision: D14491454 Differential Version: 75964011
Differential Revision: D14512187 Differential Version: 75964010
Differential Revision: D14512189 Differential Version: 7596401
Differential Revision: D14513420 Differential Version: 75964016
Differential Revision: D14514231 Differential Version: 75964014
Differential Revision: D14514239 Differential Version: 75964017
Differential Revision: D14514231 Differential Version: 7607057
Differential Revision: D14514239 Differential Version: 76260754
Differential Revision: D14552738 Differential Version: 76260721
Differential Revision: D14491454 Differential Version: 76271259
Differential Revision: D14572347 Differential Version: 77381528
Differential Revision: D14572346 Differential Version: 77381526
Differential Revision: D14653005 Differential Version: 77381560
Differential Revision: D14603258 Differential Version: 77381573
Differential Revision: D14514218 Differential Version: 77381582
Differential Revision: D14514231 Differential Version: 77424609
Differential Revision: D14514239 Differential Version: 77424614
Differential Revision: D14552738 Differential Version: 77424606
Differential Revision: D14572347 Differential Version: 77424594
Differential Revision: D14572346 Differential Version: 77424595
Differential Revision: D14653005 Differential Version: 7742460
Differential Revision: D14603258 Differential Version: 77424605
Differential Revision: D14514218 Differential Version: 77424600
Differential Revision: D14514231 Differential Version: 77453772
Differential Revision: D14514239 Differential Version: 77453786
Differential Revision: D14552738 Differential Version: 77453787
Differential Revision: D14572347 Differential Version: 77453785
Differential Revision: D14572346 Differential Version: 77453782
Differential Revision: D14653005 Differential Version: 77453775
Differential Revision: D14603258 Differential Version: 77453771
Differential Revision: D14514218 Differential Version: 77453783
Differential Revision: D14514218 Differential Version: 77464745
dzhulgakov
approved these changes
Apr 1, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 1, 2019
Summary: Pull Request resolved: pytorch/pytorch#18444 This adds the deprecated function based API to c10::RegisterOperators(). This is the API currently exposed under jit::RegisterOperators() and we need to support it for backwards compatibility. Reviewed By: dzhulgakov Differential Revision: D14514218 fbshipit-source-id: c77676851cfd431d66f18fd8038cf153a3a7d7cc
|
This pull request has been merged in 723ce02. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #18444 deprecated function based API 💛
:white_circle: #18542 Deprecated lambda based API 💚
:white_circle: #18547 Improve and test error messages for signature mismatches 💚
:white_circle: #18550 Improve compiler error messages of the op registration API 💚
:white_circle: #18551 Allow registering an operator schema without a kernel 💚
:white_circle: #18577 Register operators by passing arguments to RegisterOperators constructor 💛
:white_circle: #18592 [wip] Move ATen-core target one directory up 💛
:white_circle: #18593 [wip] Split function schema parser from operator 💛
:white_circle: #18594 [wip] Use function schema parser from op registration API 💛
:white_circle: #18597 [wip] Rewrite test cases with string based schema 💛
:white_circle: #18599 [wip] Use string based schema for exposing caffe2 ops 💛
:white_circle: #18600 [wip] Remove FunctionSchema based registration APIs 💛
This adds the deprecated function based API to c10::RegisterOperators().
This is the API currently exposed under jit::RegisterOperators() and we need to support it for backwards compatibility.
Differential Revision: D14514218