Add aten mkldnn view operator #19209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D14894545 Differential Version: 79209391
This was referenced Apr 12, 2019
gchanan
requested changes
Apr 12, 2019
bddppq
added
the
module: mkldnn
Differential Revision: D14894545 Differential Version: 79296739
Differential Revision: D14894545 Differential Version: 79299280
Differential Revision: D14894545 Differential Version: 79689951
Differential Revision: D14894545 Differential Version: 79698399
Differential Revision: D14894545 Differential Version: 79729548
Differential Revision: D14894545 Differential Version: 80386620
Differential Revision: D14894545 Differential Version: 80533702
Differential Revision: D14894545 Differential Version: 8053430
Differential Revision: D14894545 Differential Version: 80534907
Differential Revision: D14894545 Differential Version: 80541663
Differential Revision: D14894545 Differential Version: 80564049
Differential Revision: D14894545 Differential Version: 80580143
Differential Revision: D14894545 Differential Version: 80683618
dzhulgakov
approved these changes
Apr 25, 2019
| namespace at { | ||
| namespace native { | ||
|
|
||
| Tensor mkldnn_view(const Tensor& self, IntArrayRef size) { |
There was a problem hiding this comment.
nit: I guess you can move it out of the #ifdef as the error is regardless of whether mkldnn is compiled in
There was a problem hiding this comment.
The error messages are different though so I would prefer to keep two these two places.
| @@ -1517,6 +1517,12 @@ | |||
| variants: function, method | |||
| device_guard: False | |||
|
|
|||
| - func: mkldnn_reshape(Tensor self, int[] shape) -> Tensor | |||
| device_guard: False | |||
| requires_tensor: True | |||
There was a problem hiding this comment.
you don't need requires_tensor if you have dispatch
There was a problem hiding this comment.
yep I know this, just for documentation purpose :-)
Differential Revision: D14894545 Differential Version: 80773734
Differential Revision: D14894545 Differential Version: 80780047
Differential Revision: D14894545 Differential Version: 80785118
Differential Revision: D14894545 Differential Version: 80799728
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 26, 2019
Summary: Pull Request resolved: pytorch/pytorch#19209 Reviewed By: dzhulgakov Differential Revision: D14894545 fbshipit-source-id: 69455184811de1d1444b5d494e4a9d8c83301431
|
This pull request has been merged in 48b81da. |
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Pull Request resolved: pytorch#19209 Reviewed By: dzhulgakov Differential Revision: D14894545 fbshipit-source-id: 69455184811de1d1444b5d494e4a9d8c83301431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #19633 Add is_mkldnn to at::Tensor 💚
:white_circle: #19204 Add aten mkldnn conv2d operator 💚
:white_circle: #19205 Add aten mkldnn ops: relu, max_pool2d and avg_pool2d 💚
:white_circle: #19206 Add aten mkldnn batch_norm operator 💚
:white_circle: #19207 Add aten mkldnn add operator 💚
:black_circle: #19209 Add aten mkldnn view operator 💚
:white_circle: #19210 Add aten mkldnn linear operator 💚
:white_circle: #19648 Adjust resnext run script 💚
Pull Request resolved: #19209
Differential Revision: D14894545