Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotate circleci keys #19981

Closed
wants to merge 1 commit into from
Closed

Rotate circleci keys #19981

wants to merge 1 commit into from

Conversation

pjh5
Copy link
Contributor

@pjh5 pjh5 commented Apr 30, 2019

No description provided.

@pytorchbot pytorchbot added the module: ci Related to continuous integration label Apr 30, 2019
yf225
yf225 requested changes May 1, 2019
View reviewed changes
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we wrap all places where we do AWS_ACCESS_KEY_ID= with set +x/set -x? It seems some of them are missing, e.g.

pytorch/.circleci/config.yml

Lines 1213 to 1214 in ba84ad0

export AWS_ACCESS_KEY_ID=${CIRCLECI_AWS_ACCESS_KEY_FOR_SCCACHE_S3_BUCKET_V3}
export AWS_SECRET_ACCESS_KEY=${CIRCLECI_AWS_SECRET_KEY_FOR_SCCACHE_S3_BUCKET_V3}
.

facebook-github-bot
facebook-github-bot reviewed May 1, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjh5 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pjh5 merged this pull request in 0da0c4b.

@pjh5 pjh5 deleted the rotate branch May 2, 2019 00:06
zhangguanheng66 pushed a commit to zhangguanheng66/pytorch that referenced this pull request May 6, 2019
@pjh5
Rotate circleci keys
e9442b0 
Summary: Pull Request resolved: pytorch#19981

Differential Revision: D15174219

Pulled By: pjh5

fbshipit-source-id: 205952aa90ed93f193f40d4293f5a8d82fa33ed6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@yf225 yf225 yf225 approved these changes

Assignees
No one assigned
Labels
module: ci Related to continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pjh5 @facebook-github-bot @yf225 @pytorchbot