[jit] allow classes to be used in their own methods #20106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes to how class names are resolved broke this functionality. We switched to use the python resolver to find classes, but a class is not defined in python until *after* the compilation for that class complete. This PR gives PythonResolver the knowledge of the currently compiling class so it can resolve that name correctly.
This was referenced May 3, 2019
[jit] allow classes to be used in their own methods Recent changes to how class names are resolved broke this functionality. We switched to use the python resolver to find classes, but a class is not defined in python until *after* the compilation for that class complete. This PR gives PythonResolver the knowledge of the currently compiling class so it can resolve that name correctly. gh-metadata: pytorch pytorch 20106 gh/suo/35/head
[jit] allow classes to be used in their own methods Recent changes to how class names are resolved broke this functionality. We switched to use the python resolver to find classes, but a class is not defined in python until *after* the compilation for that class complete. This PR gives PythonResolver the knowledge of the currently compiling class so it can resolve that name correctly. gh-metadata: pytorch pytorch 20106 gh/suo/35/head
[jit] allow classes to be used in their own methods Recent changes to how class names are resolved broke this functionality. We switched to use the python resolver to find classes, but a class is not defined in python until *after* the compilation for that class complete. This PR gives PythonResolver the knowledge of the currently compiling class so it can resolve that name correctly. gh-metadata: pytorch pytorch 20106 gh/suo/35/head
zdevito
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Recent changes to how class names are resolved broke this functionality.
We switched to use the python resolver to find classes, but a class is not
defined in python until after the compilation for that class
complete.
This PR gives PythonResolver the knowledge of the currently compiling
class so it can resolve that name correctly.
Differential Revision: D15202261