Add USE_NAMEDTENSOR compilation flag. #20162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the NAMEDTENSOR_ENABLED macro (in cpp) and tools.setup_helpers.env.NAMEDTENSOR_ENABLED. Test Plan: - Compile with NAMEDTENSOR_ENABLED=1. Verify that `torch.__config__.show()` has -DNAMEDTENSOR_ENABLED in the CXX flags. - Compile without the flag. Verify that `-DNAMEDTENSOR_ENABLED` is not present in `torch.__config__.show()`.
This was referenced May 6, 2019
Add USE_NAMEDTENSOR compilation flag. Sets the NAMEDTENSOR_ENABLED macro (in cpp) and tools.setup_helpers.env.NAMEDTENSOR_ENABLED. Test Plan: - Compile with NAMEDTENSOR_ENABLED=1. Verify that `torch.__config__.show()` has -DNAMEDTENSOR_ENABLED in the CXX flags. - Compile without the flag. Verify that `-DNAMEDTENSOR_ENABLED` is not present in `torch.__config__.show()`. gh-metadata: pytorch pytorch 20162 gh/zou3519/32/head
gchanan
reviewed
May 7, 2019
| @@ -175,6 +175,7 @@ def run_cmake(version, | |||
| USE_CUDA=USE_CUDA, | |||
| USE_DISTRIBUTED=USE_DISTRIBUTED, | |||
| USE_FBGEMM=not (check_env_flag('NO_FBGEMM') or check_negative_env_flag('USE_FBGEMM')), | |||
| NAMEDTENSOR_ENABLED=(check_env_flag('USE_NAMEDTENSOR') or check_negative_env_flag('NO_NAMEDTENSOR')), | |||
There was a problem hiding this comment.
why do you need to check the env flag here when other examples (e.g. USE_MKLDNN) don't need to?
There was a problem hiding this comment.
@gchanan the other examples do, somewhere down the line. Here is where the USE_MKLDNN flag is defined, for example:
pytorch/tools/setup_helpers/env.py
Line 63 in bc53984
There was a problem hiding this comment.
ok, I don't know why we don't do things in one place, but if it works, it works!
gchanan
approved these changes
May 7, 2019
Add USE_NAMEDTENSOR compilation flag. Sets the NAMEDTENSOR_ENABLED macro (in cpp) and tools.setup_helpers.env.NAMEDTENSOR_ENABLED. Test Plan: - Compile with NAMEDTENSOR_ENABLED=1. Verify that `torch.__config__.show()` has -DNAMEDTENSOR_ENABLED in the CXX flags. - Compile without the flag. Verify that `-DNAMEDTENSOR_ENABLED` is not present in `torch.__config__.show()`. gh-metadata: pytorch pytorch 20162 gh/zou3519/32/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 9, 2019
Summary: Pull Request resolved: pytorch/pytorch#20162 ghimport-source-id: 0efcd67f04aa087e1dd5faeee550daa2f13ef1a5 Reviewed By: gchanan Differential Revision: D15278211 Pulled By: zou3519 fbshipit-source-id: 6fee981915d83e820fe8b50a8f59da22a428a9bf
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Sets the NAMEDTENSOR_ENABLED macro (in cpp) and
tools.setup_helpers.env.NAMEDTENSOR_ENABLED.
Test Plan:
torch.__config__.show()has -DNAMEDTENSOR_ENABLED in the CXX flags.-DNAMEDTENSOR_ENABLEDis notpresent in
torch.__config__.show().gh-metadata: pytorch pytorch 20162 gh/zou3519/32/head
Differential Revision: D15278211