New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ONNX Export Slice and Flip ops for opset 10 #20533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@houseroad any updates on this? |
…hdr/pytorch into lahaidar/onnx_export_slice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@pytorchbot retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@pytorchbot rebase this please |
@@ -118,3 +117,45 @@ def symbolic_fn(g, input, kernel_size, stride, padding, ceil_mode, count_include | |||
avg_pool1d = _avg_pool('avg_pool1d', _single) | |||
avg_pool2d = _avg_pool('avg_pool2d', _pair) | |||
avg_pool3d = _avg_pool('avg_pool3d', _triple) | |||
|
|||
|
|||
def slice_op(g, input, axes, starts, ends, steps=None, dynamic_slice=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, is this still necessary? oh you call it in the _slice_op...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you @houseroad!! |
@houseroad merged this pull request in cc85c3d. |
No description provided.