Half fixes for ATen #2070
Closed
Half fixes for ATen #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soumith Is there a reason why in torch/lib/ATen/Half.h cuda_runtime.h was included instead of cuda.h? |
|
@csarofeen i dont remember. Maybe @zdevito remembers. |
|
@csarofeen GPU contbuilds are failing on this PR: https://build.pytorch.org/job/pytorch-PR-py2-linux/405//console |
|
No reason, cuda.h is fine. |
|
I wanted to get rid of cuda_runtime include but turns out I not only needed that but cuda.h as well for the version check on CUDA. |
|
this was merged into master. |
zou3519
pushed a commit
to zou3519/pytorch
that referenced
this pull request
Mar 30, 2018
* Trying fuller cuda_cull * changes * Migrating to conda-forge for openmpi * Adding openmpi * Adding leveldb * Fixing unrelated minor conda bug * Another unrelated fix
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Oct 18, 2022
Co-authored-by: Naoya Maruyama <nmaruyama@nvidia.com> Co-authored-by: Xiang Gao <qasdfgtyuiop@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for CUDA 9