Re-add Tensor.T #21175
Re-add Tensor.T #21175
Conversation
…everse dimensions" This reverts commit 0544a49.
pytorchbot
added
module: autograd
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Hypothesis: Windows is sorting capitalized names differently than uncapitalized names. If this is true, any |
|
@pytorchbot retest this please |
|
@ezyang I don't think it is related to the order of tests executing, since running On the other hand, I wouldn't be surprised if capitalization is involved somehow, e.g. with symbols in the binary being sorted in a different order and invoking some kind of non-determinism. |
|
@pytorchbot rebase this please |
|
@pytorchbot retest this please |
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pytorchbot rebase this please |
This reverts commit 0962351.
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@umanwizard merged this pull request in e268fc9. |
Summary: Something flaky is going on with `test_inplace_view_saved_output` on Windows. With my PR #20598 applied, the test fails, even though there is no obvious reason it should be related, so the PR was reverted. Based on commenting out various parts of my change and re-building, I think the problem is with the name -- renaming everything from `T` to `asdf` seems to make the test stop failing. I can't be sure that this is actually the case though, since I could just be seeing patterns in non-deterministic build output... I spoke with colesbury offline and we agreed that it is okay to just disable this test on Windows for now and not block landing the main change. He will look into why it is failing. **Test Plan:** I will wait to make sure the Windows CI suite passes before landing this. Pull Request resolved: pytorch/pytorch#21175 Differential Revision: D15566970 Pulled By: umanwizard fbshipit-source-id: edf223375d41faaab0a3a14dca50841f08030da3
Something flaky is going on with
test_inplace_view_saved_outputon Windows.With my PR #20598 applied, the test fails, even though there is no obvious reason it should be related, so the PR was reverted.
Based on commenting out various parts of my change and re-building, I think the problem is with the name -- renaming everything from
Ttoasdfseems to make the test stop failing. I can't be sure that this is actually the case though, since I could just be seeing patterns in non-deterministic build output...I spoke with @colesbury offline and we agreed that it is okay to just disable this test on Windows for now and not block landing the main change. He will look into why it is failing.
Test Plan: I will wait to make sure the Windows CI suite passes before landing this.