[pytorch] build torch for libtorch mobile build #21234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Since recent unification of caffe2 and torch library we stop building torch for mobile. This diff re-enables torch build for libtorch mobile build unless BUILD_CAFFE2_MOBILE is set to TRUE. BUILD_CAFFE2_MOBILE is used to build old libcaffe2 library which will be deprecated. We can remove these conditions after the deprecation. Test Plan: Build mobile library and make sure it can run pytorch model on Android.
soumith
approved these changes
Jun 1, 2019
orionr
approved these changes
Jun 3, 2019
pjh5
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Since recent unification of caffe2 and torch library we stop building
torch for mobile. This diff re-enables torch build for libtorch mobile
build unless BUILD_CAFFE2_MOBILE is set to TRUE.
BUILD_CAFFE2_MOBILE is used to build old libcaffe2 library which will
be deprecated. We can remove these conditions after the deprecation.
Test Plan:
Build mobile library and make sure it can run pytorch model on Android.
Differential Revision: D15616540