Make .circleci Conf class uses dataclasses; use types. #21284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As .circleci config generation script is Python 3 only, let's use some very helpful Python 3 affordances, namely dataclass, which automatically generates constructors and printing functions for "data" like classes. Actual mypy checking of these scripts is not quite here yet. Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Make PyTorch Conf class uses dataclasses; use types. As .circleci config generation script is Python 3 only, let's use some very helpful Python 3 affordances, namely dataclass, which automatically generates constructors and printing functions for "data" like classes. Actual mypy checking of these scripts is not quite here yet. Signed-off-by: Edward Z. Yang <ezyang@fb.com> gh-metadata: pytorch pytorch 21284 gh/ezyang/152/head
kostmo
approved these changes
Jun 3, 2019
ezyang
changed the title
Make .circleci Conf class uses dataclasses; use types. As .circleci config generation script is Python 3 only, let's use some very helpful Python 3 affordances, namely dataclass, which automatically generates constructors and printing functions for "data" like classes. Actual mypy checking of these scripts is not quite here yet. Signed-off-by: Edward Z. Yang <ezyang@fb.com> gh-metadata: pytorch pytorch 21284 gh/ezyang/152/head
Make .circleci Conf class uses dataclasses; use types. As .circleci config generation script is Python 3 only, let's use some very helpful Python 3 affordances, namely dataclass, which automatically generates constructors and printing functions for "data" like classes. Actual mypy checking of these scripts is not quite here yet. Signed-off-by: Edward Z. Yang <ezyang@fb.com> gh-metadata: pytorch pytorch 21284 gh/ezyang/152/head
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
As .circleci config generation script is Python 3 only, let's use
some very helpful Python 3 affordances, namely dataclass, which
automatically generates constructors and printing functions for
"data" like classes.
Actual mypy checking of these scripts is not quite here yet.
Signed-off-by: Edward Z. Yang ezyang@fb.com
gh-metadata: pytorch pytorch 21284 gh/ezyang/152/head
Differential Revision: D15621908