Move redundant code that checks NumPy during build to a helper module and add an option to disable building with NumPy #21417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: build
soumith
approved these changes
Jun 5, 2019
xuhdev
changed the title
|
@soumith I've pushed another commit that adds an option for enabling and disabling NumPy build. Could you review again? If you feel it's too hard to review, I can separate it into a different PR after this is merged. Thanks! |
xuhdev
force-pushed
the
build/numpy-helper
branch
from
7d23a56
to
2399621
Compare
xuhdev
force-pushed
the
build/numpy-helper
branch
2 times, most recently
from
4670d08
to
aaa1dc3
Compare
xuhdev
force-pushed
the
build/numpy-helper
branch
from
aaa1dc3
to
f41d18d
Compare
fmassa
approved these changes
Jun 6, 2019
There was a problem hiding this comment.
@fmassa has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
approved these changes
Jun 6, 2019
|
@fmassa go ahead and merge |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 6, 2019
… and add an option to disable building with NumPy Summary: Pull Request resolved: pytorch/pytorch#21417 Reviewed By: ezyang Differential Revision: D15694357 Pulled By: fmassa fbshipit-source-id: bc1bda23349ba4531f19619fa4adecb846225c20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.