[Re-landing] Fix caffe2 windows CI for new Windows AMI #21452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
caffe2
module: build
facebook-github-bot
added
the
oncall: jit
peterjc123
requested review from
ezyang
and removed request for
ebetica,
yf225 and
goldsborough
peterjc123
force-pushed
the
caffe_ci_fix_2
branch
from
859aa2e
to
417878f
Compare
peterjc123
force-pushed
the
caffe_ci_fix_2
branch
2 times, most recently
from
870956e
to
8a47868
Compare
ezyang
approved these changes
Jun 6, 2019
(cherry picked from commit ce4a9c4) Fix caffe2 ci job for new Windows AMI (cherry picked from commit 67d1093582699788b3098c719f7b23c9bd30f9f5) (cherry picked from commit 4c52769) Install jit test binaries Install test_api binaries Path fixes More path changes More path fixes Apply INSTALL_TEST check Fix dir names Fix path More path fixes Try path debug Fix paths Path try 1
peterjc123
force-pushed
the
caffe_ci_fix_2
branch
from
005e82f
to
fabc809
Compare
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 6, 2019
Summary: Fixes #21026. 1. Improve build docs for Windows 2. Change `BUILD_SHARED_LIBS=ON` for Caffe2 local builds 3. Change to out-source builds for LibTorch and Caffe2 (transferred to #21452) Pull Request resolved: #21190 Differential Revision: D15695223 Pulled By: ezyang fbshipit-source-id: 0ad69d7553a40fe627582c8e0dcf655f6f63bfdf
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 6, 2019
Summary: The alternative of #21410. Pull Request resolved: pytorch/pytorch#21452 Differential Revision: D15701767 Pulled By: ezyang fbshipit-source-id: e65c1d6bfcc98e88460f4a57e5b99c2f395c0ceb
yf225
pushed a commit
to yf225/pytorch
that referenced
this pull request
Jun 11, 2019
This reverts commit bb78863.
yf225
pushed a commit
to yf225/pytorch
that referenced
this pull request
Jun 12, 2019
)"" This reverts commit 5519f90.
|
Reverting this PR because it breaks libtorch binary build (sample error: https://circleci.com/gh/pytorch/pytorch/1939687). |
peterjc123
added a commit
to peterjc123/pytorch
that referenced
this pull request
Jun 14, 2019
Summary: The alternative of pytorch#21410. Pull Request resolved: pytorch#21452 Differential Revision: D15701767 Pulled By: ezyang fbshipit-source-id: e65c1d6bfcc98e88460f4a57e5b99c2f395c0ceb (cherry picked from commit bb78863)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alternative of #21410.