Add some named tensor helper functions #21636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at::internal_set_names_inplace(Tensor, optional<DimnameList>) - Used for setting the names of a tensor. This isn't a native function for performance reasons; it'll be used to implement tensor.set_names_, torch.empty(..., names=), and other functions. optional<DimnameList> Tensor::names() - Access names of a tensor. Test Plan: - New tests in [namedtensor ci]
pytorchbot
added
the
module: internals
This was referenced Jun 11, 2019
|
@nairbv can you take a look? |
This was referenced Jun 11, 2019
nairbv
reviewed
Jun 11, 2019
| @@ -257,6 +267,7 @@ class CAFFE2_API Tensor { | |||
|
|
|||
| /// Returns a `Tensor`'s dimension names data structure | |||
| NamedTensorMeta* get_named_tensor_meta() const; | |||
| NamedTensorMeta* get_named_tensor_meta(); | |||
There was a problem hiding this comment.
c++ question .... why don't these function signatures conflict?
There was a problem hiding this comment.
c++ lets you overload member methods based on const-ness.
There was a problem hiding this comment.
Err I'm changing the signatures to const NamedTensorMeta* get_named_tensor_meta() const;. I am not sure if this is actually different.
nairbv
reviewed
Jun 11, 2019
nairbv
reviewed
Jun 11, 2019
nairbv
reviewed
Jun 11, 2019
Add some named tensor helper functions at::internal_set_names_inplace(Tensor, optional<DimnameList>) - Used for setting the names of a tensor. This isn't a native function for performance reasons; it'll be used to implement tensor.set_names_, torch.empty(..., names=), and other functions. optional<DimnameList> Tensor::names() - Access names of a tensor. Test Plan: - New tests in [namedtensor ci] gh-metadata: pytorch pytorch 21636 gh/zou3519/46/head
Add some named tensor helper functions at::internal_set_names_inplace(Tensor, optional<DimnameList>) - Used for setting the names of a tensor. This isn't a native function for performance reasons; it'll be used to implement tensor.set_names_, torch.empty(..., names=), and other functions. optional<DimnameList> Tensor::names() - Access names of a tensor. Test Plan: - New tests in [namedtensor ci] gh-metadata: pytorch pytorch 21636 gh/zou3519/46/head
|
@nairbv updated |
nairbv
approved these changes
Jun 11, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 12, 2019
Summary: Pull Request resolved: pytorch/pytorch#21636 ghimport-source-id: 5eff5744cd3c80f75bdb02576be1407a64e0434d Differential Revision: D15780269 Pulled By: zou3519 fbshipit-source-id: 87ff40ffbe0ebd5fc4d105709c9f6f8dda5f9952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
at::internal_set_names_inplace(Tensor, optional)
performance reasons; it'll be used to implement tensor.set_names_,
torch.empty(..., names=), and other functions.
optional Tensor::names()
Test Plan:
gh-metadata: pytorch pytorch 21636 gh/zou3519/46/head
Differential Revision: D15780269