Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AveragePool: expand incomplete kernel_size for the C++ API #22075

Closed
wants to merge 1 commit into from
Closed

AveragePool: expand incomplete kernel_size for the C++ API #22075

wants to merge 1 commit into from

Conversation

skrah
Copy link
Contributor

@skrah skrah commented Jun 21, 2019

No description provided.

@pytorchbot pytorchbot added module: cuda Related to torch.cuda, and CUDA support in general module: operators labels Jun 21, 2019
@skrah skrah added module: cpp Related to C++ API open source module: porting Issues related to porting TH/THNN legacy to ATen native and removed module: cuda Related to torch.cuda, and CUDA support in general module: operators labels Jun 21, 2019
@skrah
Copy link
Contributor Author

skrah commented Jun 21, 2019

See #22032 for discussion. While the JIT attempts to pass complete IntArrayRefs of size 2 (or 3 for 3d), users of the C++ API do not.

mrshenli
mrshenli approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Same nit as in #22073, shall we add a test for using an integer as kernel sizes for 2d and 3d cases?

facebook-github-bot
facebook-github-bot reviewed Jun 21, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@skrah skrah mentioned this pull request Jun 21, 2019
Closed
zdevito pushed a commit to zdevito/ATen that referenced this pull request Jun 24, 2019
@skrah @facebook-github-bot
AveragePool: expand incomplete kernel_size for the C++ API
efc5665 
Summary: Pull Request resolved: pytorch/pytorch#22075

Differential Revision: D15945260

Pulled By: mrshenli

fbshipit-source-id: 827660c19ebbdb5f0aae2f4eadb6025ae2f93674
@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in 88cdc16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mrshenli mrshenli mrshenli approved these changes

Assignees
No one assigned
Labels
Merged module: cpp Related to C++ API module: porting Issues related to porting TH/THNN legacy to ATen native open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@skrah @facebook-github-bot @mrshenli @pytorchbot @mruberry