Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt into Trusty builds. #2214

Merged
merged 2 commits into from
Jul 26, 2017
Merged

Opt into Trusty builds. #2214

merged 2 commits into from
Jul 26, 2017

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Jul 26, 2017

Signed-off-by: Edward Z. Yang ezyang@fb.com

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
@soumith
Copy link
Member

soumith commented Jul 26, 2017

python 2.7.8 seems to not be supported by trusty travis

@soumith
Copy link
Member

soumith commented Jul 26, 2017

the URL it tries to download i.e. https://s3.amazonaws.com/travis-python-archives/binaries/ubuntu/14.04/x86_64/python-2.7.8.tar.bz2 does not exist.

@ezyang
Copy link
Contributor Author

ezyang commented Jul 26, 2017

Yes. According to Travis travis-ci/travis-ci#8153 they did not build this version of Python for Trusty. Is there are particular reason why this is the beginning of our version support?

@soumith
Copy link
Member

soumith commented Jul 26, 2017

it's the default python version in 12.04 if I remember correctly

@ezyang
Copy link
Contributor Author

ezyang commented Jul 26, 2017

Nope :)

But maybe there is an environment we care about where it is default. I'm looking.

UPDATE: I couldn't find anything definitive.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
@soumith soumith merged commit cb9ad7a into pytorch:master Jul 26, 2017
@cdluminate
Copy link
Contributor

Default python2 for Ubuntu releases: https://launchpad.net/ubuntu/+source/python-defaults

Default python3 for Ubuntu releases: https://launchpad.net/ubuntu/+source/python3-defaults

ruotianluo added a commit to ruotianluo/pytorch-1 that referenced this pull request Jul 31, 2017
* commit '8262920b72374b1d9643f35057663ab02ab20330': (272 commits)
  Add ATen overload to AutoGPU. (pytorch#2234)
  Add comments for default value (pytorch#2242)
  Remove dead THPP code that has been replaced with ATen objects. (pytorch#2235)
  fix a bug where an uninitialized at::Tensor was passed to createPyObject (pytorch#2239)
  Replace thpp::Tensor with ATen Tensor in autograd csrc (pytorch#2170)
  Added aarch64 support (pytorch#2226)
  Increase tol. for float tensor qr big test.
  Improve Variable.retain_grad
  add `retain_grad` method, to variable, so gradient gets stored during backpop, on non-user variables
  Implement BatchNorm double backwards (pytorch#2207)
  [bugfix] in bce_with_logits logsumexp calculation (pytorch#2221)
  fix for ATen API Change
  Opt into Trusty builds. (pytorch#2214)
  allow retain to be specified for unsafeTensorFromTH
  Deduplicate THPUtils_checkLong/THPUtils_unpackLong (pytorch#2218)
  fix osx build errors related to long/int64_t
  Note [Undefined-dim versus 0-dim]
  Remove __func__ hack in auto nn.
  Enable Conv groups gradgradchecks. (pytorch#2216)
  fix a bug where some scalars were getting truncated to integers incorrectly.
  ...
ruotianluo added a commit to ruotianluo/pytorch-1 that referenced this pull request Aug 1, 2017
* commit '8262920b72374b1d9643f35057663ab02ab20330': (272 commits)
  Add ATen overload to AutoGPU. (pytorch#2234)
  Add comments for default value (pytorch#2242)
  Remove dead THPP code that has been replaced with ATen objects. (pytorch#2235)
  fix a bug where an uninitialized at::Tensor was passed to createPyObject (pytorch#2239)
  Replace thpp::Tensor with ATen Tensor in autograd csrc (pytorch#2170)
  Added aarch64 support (pytorch#2226)
  Increase tol. for float tensor qr big test.
  Improve Variable.retain_grad
  add `retain_grad` method, to variable, so gradient gets stored during backpop, on non-user variables
  Implement BatchNorm double backwards (pytorch#2207)
  [bugfix] in bce_with_logits logsumexp calculation (pytorch#2221)
  fix for ATen API Change
  Opt into Trusty builds. (pytorch#2214)
  allow retain to be specified for unsafeTensorFromTH
  Deduplicate THPUtils_checkLong/THPUtils_unpackLong (pytorch#2218)
  fix osx build errors related to long/int64_t
  Note [Undefined-dim versus 0-dim]
  Remove __func__ hack in auto nn.
  Enable Conv groups gradgradchecks. (pytorch#2216)
  fix a bug where some scalars were getting truncated to integers incorrectly.
  ...
@ezyang ezyang deleted the pr/trusty-travis branch September 7, 2017 20:30
zou3519 pushed a commit to zou3519/pytorch that referenced this pull request Mar 30, 2018
pytorch#2214)

* Avoid duplicated log when explicitly specified engine is not available

* Update operator.cc
jjsjann123 pushed a commit to jjsjann123/pytorch that referenced this pull request Nov 29, 2022
The complex type defined by `defineComplexType` doesn't seem to work
with nvcc. When compiled with nvcc, instead of using the definitions,
include <complex>. Also disable some other parts that don't work with
<complex>.

This would of course break the complex type support, but as long as it's
not used, it shouldn't matter. Compilation with nvcc should be just
ad-hoc experiments of code modifications, so the limitation should be
fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants