Documentation cleanup #23148
Closed
Documentation cleanup #23148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z-a-f
requested review from
dzhulgakov,
jspisak and
soumith
and removed request for
dzhulgakov
Documentation cleanup gh-metadata: pytorch pytorch 23148 gh/zafartahirov/14/head
|
@pytorchbot retest this please |
Documentation cleanup gh-metadata: pytorch pytorch 23148 gh/zafartahirov/14/head
soumith
requested changes
Jul 24, 2019
torch/nn/quantized/functional.py
Outdated
| :attr:`inplace` is not supported for the quantized relu. | ||
|
|
||
| Applies the rectified linear unit function element-wise. See | ||
| :class:`~torch.nn.quantized.ReLU` for more details. |
There was a problem hiding this comment.
again, torch.nn.functional.ReLU is what you meant to type here
There was a problem hiding this comment.
Actually, about that -- don't we want to refer the functional to its module counterpart? The documentation in the torch.nn.quantized.ReLU is more relevant to this than the non-quantized counterpart
Differential Revision: [D16414202](https://our.internmc.facebook.com/intern/diff/D16414202)
Differential Revision: [D16414202](https://our.internmc.facebook.com/intern/diff/D16414202)
soumith
approved these changes
Jul 26, 2019
Differential Revision: [D16414202](https://our.internmc.facebook.com/intern/diff/D16414202)
Differential Revision: [D16414202](https://our.internmc.facebook.com/intern/diff/D16414202)
|
@zafartahirov merged this pull request in 5e4c24b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D16414202