[JIT] fix specialized list from dict keys #23267
Conversation
| template <> | ||
| c10::impl::GenericList makeListForDictValues<IValue>( | ||
| template <unsigned int Index> | ||
| c10::impl::GenericList makeGenericListForDictKeysOrValues( | ||
| const std::vector<std::pair<IValue, IValue>>& order) { | ||
| auto values = c10::impl::GenericList(c10::impl::deprecatedUntypedList()); |
There was a problem hiding this comment.
Is it possible to do c10::List<IValue> so we don't have to have a separate copy of this function for GenericLists?
There was a problem hiding this comment.
that doesn't compile. And you can't do partial template specialization so that you are only passing in the Index in
test/test_jit.py
Outdated
| def specialized_list(): | ||
| return {1: 1, 2: 2}.keys() | ||
|
|
||
| self.assertTrue(set(specialized_list()) == set([1, 2])) |
There was a problem hiding this comment.
This would have passed with deprecatedUntypedList before, how does it test the change?
There was a problem hiding this comment.
now it is testing an op with a specialized list. i don't know what deprecatedUntypedList is
There was a problem hiding this comment.
okay added op that uses specialized list
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Add `sorted` keyword to JIT for lists and dicts. This desugars to a list copy and a call to `list.sort()`. Since we don't have interfaces yet I implement it in terms of `list.sort()`. When we do we can re-visit implementing this op in a different manner. The test fails bc of a fix to specialized lists which is landing here: #23267 Ignore the first commit because it is formatting, plz use clang_format ppl :'( Pull Request resolved: #23274 Differential Revision: D16527323 Pulled By: eellison fbshipit-source-id: aed8faef23cb790b9af036cd6c1b9b1d7066345d
Summary: Add `sorted` keyword to JIT for lists and dicts. This desugars to a list copy and a call to `list.sort()`. Since we don't have interfaces yet I implement it in terms of `list.sort()`. When we do we can re-visit implementing this op in a different manner. The test fails bc of a fix to specialized lists which is landing here: pytorch/pytorch#23267 Ignore the first commit because it is formatting, plz use clang_format ppl :'( Pull Request resolved: pytorch/pytorch#23274 Differential Revision: D16527323 Pulled By: eellison fbshipit-source-id: aed8faef23cb790b9af036cd6c1b9b1d7066345d
Previously we weren't specializing the list returned from
dict.keys()