Use prerendered KaTeX in docs. #23376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses master version of sphinxcontrib-katex as it only recently got prerender support. Signed-off-by: Edward Z. Yang <ezyang@fb.com>
pytorchbot
added
module: build
ezyang
added a commit
that referenced
this pull request
Jul 25, 2019
This uses master version of sphinxcontrib-katex as it only recently got prerender support. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 831c1e7dbbec6db3e9c3deb1d41c92c6f4bc9806 Pull Request resolved: #23376
soumith
approved these changes
Jul 25, 2019
|
This, as done in this PR, is a bit slower than imgmath svg/png. Check out #20984 (comment) for more details. |
|
We should add some extra preloads for this, and slim down the JavaScript, before landing this. |
This uses master version of sphinxcontrib-katex as it only recently got prerender support. Fixes #20984 Signed-off-by: Edward Z. Yang <ezyang@fb.com>
ezyang
added a commit
that referenced
this pull request
Jul 31, 2019
This uses master version of sphinxcontrib-katex as it only recently got prerender support. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 4e8d4aba1831163a96bd9c8070828e4f6d3df657 Pull Request resolved: #23376
soumith
pushed a commit
that referenced
this pull request
Aug 7, 2019
Summary: Pull Request resolved: #23376 This uses master version of sphinxcontrib-katex as it only recently got prerender support. Fixes #20984 Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Differential Revision: D16582064 Pulled By: ezyang fbshipit-source-id: 9ef24c5788c19572515ded2db2e8ebfb7a5ed44d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This uses master version of sphinxcontrib-katex as it only
recently got prerender support.
Fixes #20984
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D16582064