Add logging to Alias Analysis #23383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZolotukhinM
approved these changes
Jul 25, 2019
| std::string AliasDb::toString() const { | ||
| std::stringstream ss{}; | ||
| std::unordered_map<size_t, Element*> indexToElementMap; | ||
| // ss << "\n===1. GRAPH===\n"; |
There was a problem hiding this comment.
Should either remove or uncomment I guess.
There was a problem hiding this comment.
Uncommented it 😄 Thanks for reviewing it so promptly!
Krovatkin
force-pushed
the
krovatkin/alias_analysis_log
branch
from
c3e0bed
to
e5cad28
Compare
There was a problem hiding this comment.
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
fix a typo missing return stmt uncomment step1 this->toString fix comp build errors using toString()
Krovatkin
force-pushed
the
krovatkin/alias_analysis_log
branch
from
07393bc
to
63d3f3f
Compare
There was a problem hiding this comment.
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@Krovatkin merged this pull request in 3b6aa9a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.