Fix named tensor build by enabling tensor.is_pinned and removing support for clone() #23597
Conversation
zou3519
force-pushed
the
fix-namedtensor-build2
branch
from
970c285
to
066c4e9
Compare
|
Thanks! Sorry about breaking this. What does this |
No worries. Because named tensors are still experimental, if the build/test fails, I'm responsible for fixing it.
named tensor CI build is always green on pull requests because it doesn't do anything. This reflects how current pytorch devs should not worry about it. If someone includes [namedtensor ci] in the pull request body, then it will actually run.
https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/README.md#named_guard |
There was a problem hiding this comment.
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zou3519
force-pushed
the
fix-namedtensor-build2
branch
from
066c4e9
to
33d95b4
Compare
zou3519
changed the title
There was a problem hiding this comment.
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
for clone() `is_pinned` was moved to native_functions.yaml, disabling it for named tensors. This PR re-enables its usage for named tensors. I wrote a named inference rule for torch.clone(), but something happened to it. Disable it for now so we can get the namedtensor ci to be green. Test Plan: - Run tests [namedtensor ci]
zou3519
force-pushed
the
fix-namedtensor-build2
branch
from
33d95b4
to
d1395db
Compare
There was a problem hiding this comment.
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…ort for clone() (#23597) Summary: `is_pinned` was moved to native_functions.yaml, disabling it for named tensors. This PR re-enables its usage for named tensors. I wrote a named inference rule for torch.clone(), but something happened to it. Disable it for now so we can get the namedtensor ci to be green. Pull Request resolved: pytorch/pytorch#23597 Test Plan: - run tests [namedtensor ci] Differential Revision: D16581771 Pulled By: zou3519 fbshipit-source-id: 498018cdc55e269bec80634b8c0a63ba5c72914b
is_pinnedwas moved to native_functions.yaml, disabling it for namedtensors. This PR re-enables its usage for named tensors.
I wrote a named inference rule for torch.clone(), but something happened
to it. Disable it for now so we can get the namedtensor ci to be green.
Test Plan: