Allow empty Variables to be saved for backwards #23618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: For example: `save_for_backward({Variable(), x, Variable()})` should be allowed, so that this is consistent with the python API behaviour.
Test Plan: Added a test.
Reviewers:
Subscribers:
Tasks:
Tags:
malvika2147
requested review from
ebetica,
goldsborough and
yf225
as code owners
pytorchbot
added
module: autograd
ezyang
approved these changes
Jul 31, 2019
|
This pull request has been merged in ec13f18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: For example:
save_for_backward({Variable(), x, Variable()})should be allowed, so that this is consistent with the python API behaviour.Test Plan: Added a test similar to the python test
test_save_none_for_backwardfrom test_autograd.py.Differential Revision: D16589402