[quantization] fix conv2d #23690
Closed
[quantization] fix conv2d #23690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z-a-f
approved these changes
Aug 1, 2019
jerryzh168
reviewed
Aug 1, 2019
torch/nn/quantized/functional.py
Outdated
| prepacked_weight, bias, | ||
| stride, padding, dilation, | ||
| groups, scale, zero_point).permute([0, 3, 1, 2]) | ||
| return _ops.quantized.fbgemm_conv2d(input.permute([0, 2, 3, 1]), |
There was a problem hiding this comment.
maybe remove as _ops in the import?
There was a problem hiding this comment.
The reason it was there was so that the user wouldn't have ops in their top level after from torch.quantized.functional import *, but I guess we don't need that restriction
There was a problem hiding this comment.
maybe use torch.ops directly then?
[quantization] fix conv2d gh-metadata: pytorch pytorch 23690 gh/jamesr66a/28/head
jerryzh168
approved these changes
Aug 2, 2019
This was referenced Aug 2, 2019
Closed
|
@jamesr66a merged this pull request in 3314d60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D16610734