In the CUDA implementation of erfinv, erfinv() should be used for double #25337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cuda
|
It is possible to test cover, to make sure that we are not repeating this error again. |
xuhdev
force-pushed
the
erfinv
branch
4 times, most recently
from
2a2dbb8
to
7a43dfb
Compare
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
xuhdev
force-pushed
the
erfinv
branch
3 times, most recently
from
fef39cf
to
1a88df9
Compare
|
@VitalyFedyunin Could you re-import please? Now this should be ready. Also, I've added test to ensure the accuracy for double |
|
@pytorchbot rebase this please |
|
@VitalyFedyunin Could you re-review this, please? Thanks! |
|
@pytorchbot rebase this please |
zou3519
reviewed
Sep 9, 2019
This best preserves accuracy, while erfinvf() should be used for half and float.
There was a problem hiding this comment.
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 10, 2019
…ble (#25337) Summary: This best preserves accuracy, while erfinvf() should be used for half and float. This is also consistent with the implementation before the migration: pytorch/pytorch#24943 Pull Request resolved: pytorch/pytorch#25337 Differential Revision: D17102333 Pulled By: zou3519 fbshipit-source-id: 5178cff534cf5f10d86ab04d4b6c1779ffedf49e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This best preserves accuracy, while erfinvf() should be used for half and float.
This is also consistent with the implementation before the migration: #24943