Improve Tensor type hints
#28578
Closed
Improve Tensor type hints
#28578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add some missing attributes - Add some missing methods - Type read-only attributes as properties Fixes pytorch#28457
There was a problem hiding this comment.
@fmassa has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
I suspect that python/mypy#4146 could cause an issue with the layout property.
|
python/mypy#4146 is causing problems it seems. I'll have a look. Edit: Should be good now. |
Workaround for python/mypy#4146
There was a problem hiding this comment.
@fmassa has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
fmassa
approved these changes
Oct 25, 2019
There was a problem hiding this comment.
@fmassa has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've typed some attributes from
pytorch/torch/csrc/autograd/python_variable.cpp
Line 490 in ee920b9
dtype,shape,deviceornamesdirectly is not part of the public API, let me know and I'll make them properties as well.I've also added
__len__,__iter__and__contains__, which means MyPy will no longer complain aboutlen(t),t1 in t2andfor t1 in t2.Shameless plug: I have another typing-related PR here that needs review: #27445
Fixes #28457