[rpc] add default arg for init_method #30208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 21, 2019
Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. ghstack-source-id: 94325445 Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/)
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 21, 2019
Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. ghstack-source-id: 94327311 Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/)
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 21, 2019
Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. ghstack-source-id: 94329214 Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/)
rohan-varma
changed the title
xush6528
reviewed
Nov 21, 2019
| @@ -15,6 +15,7 @@ namespace rpc { | |||
| struct RpcBackendOptions { | |||
| RpcBackendOptions() noexcept = default; | |||
There was a problem hiding this comment.
There is an relevant compiling error.
Try removing noexcept ?
I guess it's a mismatch with std::string's default constructor.
mrshenli
reviewed
Nov 21, 2019
| init_method(str): backend specific init arguments. | ||
| init_method(str): URL specifying how to initialize the | ||
| RPC backend. Default is "env://" if no | ||
| ``init_method`` is specified. | ||
| rank (int): a globally unique id/rank of this node. | ||
| world_size (int): The number of workers in the group. | ||
| rpc_backend_options (RpcBackendOptions): The options passed to RpcAgent |
There was a problem hiding this comment.
(This can come in a followup PR) Do we have docs for rpc_backend_options to show how to construct it, probably with a customized init_method?
There was a problem hiding this comment.
I'll work on this in a follow up PR.
xush6528
reviewed
Nov 21, 2019
pritamdamania87
suggested changes
Nov 21, 2019
torch/distributed/rpc/__init__.py
Outdated
| @@ -50,15 +49,24 @@ def init_rpc( | |||
| ``Worker1``) Name can only contain number, alphabet, | |||
| underscore, and/or dash, and must be shorter than | |||
| 128 characters. | |||
| init_method(str): backend specific init arguments. | |||
| init_method(str): URL specifying how to initialize the | |||
There was a problem hiding this comment.
Why do we still have this in the docs? Isn't this parameter removed from init_rpc now?
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 22, 2019
Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. ghstack-source-id: 94407223 Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/)
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 22, 2019
Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. ghstack-source-id: 94411767 Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/)
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 22, 2019
Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. ghstack-source-id: 94417175 Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/)
mrshenli
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
This stack looks good to go. Test failures are irrelevant:
Nov 22 10:11:16 ======================================================================
Nov 22 10:11:16 FAIL [0.024s]: test_pytorch_graph (__main__.TestTensorBoardPytorchGraph)
Nov 22 10:11:16 ----------------------------------------------------------------------
Nov 22 10:11:16 Traceback (most recent call last):
Nov 22 10:11:16 File "test_tensorboard.py", line 507, in test_pytorch_graph
Nov 22 10:11:16 self.assertTrue(compare_proto(graphdef, self))
Nov 22 10:11:16 AssertionError: False is not true
Nov 22 10:11:16
Nov 22 10:11:16 ----------------------------------------------------------------------
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 22, 2019
Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. ghstack-source-id: 94459011 Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/)
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 23, 2019
Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Also fixes some docs. ghstack-source-id: 94480407 Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/)
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 24, 2019
Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Removes `init_method` arg from rpc.init_rpc. Also fixes some docs. ghstack-source-id: 94490244 Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/)
Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 25, 2019
Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Removes `init_method` arg from rpc.init_rpc. Also fixes some docs. ghstack-source-id: 94500475 Differential Revision: [D18630074](https://our.internmc.facebook.com/intern/diff/D18630074/)
rohan-varma
added a commit
that referenced
this pull request
Nov 28, 2019
Summary: Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Removes `init_method` arg from rpc.init_rpc. Also fixes some docs. ghstack-source-id: 94500475 Test Plan: Unit tests pass. Reviewed By: mrshenli Differential Revision: D18630074 fbshipit-source-id: 04b7dd7ec96f4c4da311b71d250233f1f262135a
This was referenced Nov 28, 2019
mingbowan
pushed a commit
that referenced
this pull request
Dec 3, 2019
Summary: Pull Request resolved: #30208 Adds default arg for init_method so users don't have to pass this in, and moves it to `RpcBackendOptions` struct. Removes `init_method` arg from rpc.init_rpc. Also fixes some docs. ghstack-source-id: 94500475 Test Plan: Unit tests pass. Reviewed By: mrshenli Differential Revision: D18630074 fbshipit-source-id: 04b7dd7ec96f4c4da311b71d250233f1f262135a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Adds default arg for init_method so users don't have to pass this in,
and moves it to
RpcBackendOptionsstruct.Differential Revision: D18630074