Support broadcast for quantized mul kernel #30442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As next step, I will add the vectorized implementation for performance. |
|
Any update on this? |
lly-zero-one
changed the title
There was a problem hiding this comment.
@lly-zero-one has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jamesr66a
approved these changes
Feb 19, 2020
|
@lly-zero-one merged this pull request in ecb05f1. |
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Since the tensor iterator supports the broadcast, we will just remove the assertion on input shapes. Pull Request resolved: pytorch#30442 Differential Revision: D19976562 Pulled By: lly-zero-one fbshipit-source-id: 91b27fc8b2570f29d110c6df26eacdd16f587b9f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the tensor iterator supports the broadcast, we will just remove the assertion on input shapes.