added a serialize function in SGD class to utilize the existing macro for serialization/deserialization calls #30739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjali411
requested review from
ebetica,
goldsborough and
yf225
as code owners
yf225
approved these changes
Dec 4, 2019
yf225
reviewed
Dec 4, 2019
| static void serialize(Self& self, Archive& archive) { | ||
| _TORCH_OPTIM_SERIALIZE(momentum_buffers); | ||
| _TORCH_OPTIM_SERIALIZE(iteration_); | ||
| } |
There was a problem hiding this comment.
We might need to #include <torch/optim/serialize.h> in this file to fix the CI build error
There was a problem hiding this comment.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@anjali411 merged this pull request in 5687ee1. |
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
… for serialization/deserialization calls Summary: Pull Request resolved: pytorch#30739 Differential Revision: D18842908 Pulled By: anjali411 fbshipit-source-id: 7dc13ff9c4fc126790b88b1b4b5d03425c349d38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.