Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libmkl_rt, or statically link against MKL #31159

Merged
merged 2 commits into from Dec 12, 2019

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Dec 12, 2019

Stack from ghstack:

Part of removing RTLD_GLOBAL for _C.

MKL doesn't like being in a local scope, unless you use the libmkl_rt.so
variant, so I adapted our CMake configuration to either accept that or
only allow static linking.

Signed-off-by: Edward Z. Yang ezyang@fb.com

Part of removing RTLD_GLOBAL for _C.

MKL doesn't like being in a local scope, unless you use the libmkl_rt.so
variant, so I adapted our CMake configuration to either accept that or
only allow static linking.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Dec 12, 2019
Part of removing RTLD_GLOBAL for _C.

MKL doesn't like being in a local scope, unless you use the libmkl_rt.so
variant, so I adapted our CMake configuration to either accept that or
only allow static linking.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

ghstack-source-id: 1ab07cd1671d716aa88ccce62bfa788f0de87bbe
Pull Request resolved: #31159
@kostmo
Copy link
Member

kostmo commented Dec 12, 2019

CircleCI build failures summary

As of commit ee279de:

  • 2/2 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

1 new failure recognized by patterns

The following build failures don't appear to be due to upstream breakage:

See CircleCI build pytorch_linux_xenial_py3_5_test (1/1)

Step: "Test" (details)

Dec 12 05:03:50 Ran 1471 tests in 462.501s
Dec 12 05:03:50 
Dec 12 05:03:50 FAILED (failures=1, skipped=681, expected failures=2)
Dec 12 05:03:50 
Dec 12 05:03:50 Generating XML reports...
Dec 12 05:03:50 Traceback (most recent call last):
Dec 12 05:03:50   File "test/run_test.py", line 456, in <module>
Dec 12 05:03:50     main()
Dec 12 05:03:50   File "test/run_test.py", line 449, in main
Dec 12 05:03:50     raise RuntimeError(message)
Dec 12 05:03:50 RuntimeError: test_nn failed!
Dec 12 05:03:50 + cleanup
Dec 12 05:03:50 + retcode=1
Dec 12 05:03:50 + set +x
Dec 12 05:03:50 =================== sccache compilation log ===================
Dec 12 05:03:50 =========== If your build fails, please take a look at the log above for possible reasons ===========
Dec 12 05:03:50 Compile requests                  7
Dec 12 05:03:50 Compile requests executed         6
Dec 12 05:03:50 Cache hits                        0
Dec 12 05:03:50 Cache misses                      6
Dec 12 05:03:50 Cache timeouts                    0

1 failure not recognized by patterns:

Job Step
CircleCI pytorch_macos_10_13_py3_test Test

This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 4 times.

@ezyang
Copy link
Contributor Author

ezyang commented Dec 12, 2019

Hooo boy, this is the change that's causing the numeric errors.

Part of removing RTLD_GLOBAL for _C.

MKL doesn't like being in a local scope, unless you use the libmkl_rt.so
variant, so I adapted our CMake configuration to either accept that or
only allow static linking.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@ezyang ezyang merged commit ee279de into gh/ezyang/577/base Dec 12, 2019
xxtEchjovs44 pushed a commit to xxtEchjovs44/pytorch that referenced this pull request Jan 29, 2020
Part of removing RTLD_GLOBAL for _C.

MKL doesn't like being in a local scope, unless you use the libmkl_rt.so
variant, so I adapted our CMake configuration to either accept that or
only allow static linking.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

ghstack-source-id: f7c8fe043a71af62afc3336dfef4547d0acacda7
Pull Request resolved: pytorch/pytorch#31159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants