Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove simple .data from torch/nn #31482

Closed
wants to merge 7 commits into from
Closed

Conversation

albanD
Copy link
Collaborator

@albanD albanD commented Dec 19, 2019

Stack from ghstack:

Differential Revision: D19303243

@albanD albanD requested a review from apaszke as a code owner December 19, 2019 17:52
albanD added a commit that referenced this pull request Dec 19, 2019
ghstack-source-id: bbb25ff658c0f4a035f2a4bb5962be952ccc2762
Pull Request resolved: #31482
@albanD albanD requested a review from gchanan December 19, 2019 17:53
@kostmo
Copy link
Member

kostmo commented Dec 19, 2019

💊 CircleCI build failures summary and remediations

As of commit 0cd25ba:

Commit 0cd25ba was recently pushed. Waiting for builds...


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 39 times.

albanD added a commit that referenced this pull request Dec 20, 2019
ghstack-source-id: 66fda37aeaf791c309874068107e16037b272712
Pull Request resolved: #31482
albanD added a commit that referenced this pull request Dec 26, 2019
ghstack-source-id: a8dd51e51972e2c8c2f8e2f06d34c0df749c6f97
Pull Request resolved: #31482
albanD added a commit that referenced this pull request Jan 7, 2020
ghstack-source-id: 2889559a4247f6b58925c8ee87d92a3212994d48
Pull Request resolved: #31482
albanD added a commit that referenced this pull request Jan 13, 2020
ghstack-source-id: 1543bd8e29ab228d3f756d70f4b498fc3ba56528
Pull Request resolved: #31482
@albanD albanD reopened this Jan 14, 2020
@albanD
Copy link
Collaborator Author

albanD commented Jan 14, 2020

Error from the bot, this PR was not merged in the given commit

@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in 26621d1.

@albanD albanD removed the merged label Jan 14, 2020
torch/nn/modules/module.py Show resolved Hide resolved
torch/nn/modules/module.py Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in 81048c4.

@facebook-github-bot facebook-github-bot deleted the gh/albanD/22/head branch January 19, 2020 15:16
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary: Pull Request resolved: pytorch#31482

Test Plan: Imported from OSS

Differential Revision: D19303185

Pulled By: albanD

fbshipit-source-id: 610eae096bab24a7b9f651b9af2e3ecd19df55b0
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary: Pull Request resolved: pytorch#31482

Test Plan: Imported from OSS

Differential Revision: D19303243

Pulled By: albanD

fbshipit-source-id: 5afdfeb4b8382c09b9ec65acd545148ed76d4285
@albanD albanD mentioned this pull request Feb 7, 2020
15 tasks
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
Summary: Pull Request resolved: pytorch#31482

Test Plan: Imported from OSS

Differential Revision: D19303243

Pulled By: albanD

fbshipit-source-id: 5afdfeb4b8382c09b9ec65acd545148ed76d4285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants