Notify other threads before running callbacks #31713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the callbacks are heavy/slow, the other threads should be able to start work on the value of the future after the current thread moves the value and unlock the mutex. Differential Revision: [D5624371](https://our.internmc.facebook.com/intern/diff/D5624371/) [ghstack-poisoned]
xush6528
added a commit
that referenced
this pull request
Dec 30, 2019
In case the callbacks are heavy/slow, the other threads should be able to start work on the value of the future after the current thread moves the value and unlock the mutex. Differential Revision: [D5624371](https://our.internmc.facebook.com/intern/diff/D5624371/) ghstack-source-id: 96189462 Pull Request resolved: #31713
💊 CircleCI build failures summary and remediationsAs of commit c258e51: Commit c258e51 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 5 times. |
- In case the callbacks are heavy/slow, the other threads should be able to start work on the value of the future after the current thread moves the value and unlock the mutex. - `completed()` is not inlined. Avoid function call overhead. Differential Revision: [D5624371](https://our.internmc.facebook.com/intern/diff/D5624371/) [ghstack-poisoned]
xush6528
added a commit
that referenced
this pull request
Jan 15, 2020
Pull Request resolved: #31713 - In case the callbacks are heavy/slow, the other threads should be able to start work on the value of the future after the current thread moves the value and unlock the mutex. - `completed()` is not inlined. Avoid function call overhead. ghstack-source-id: 96694593 Differential Revision: [D5624371](https://our.internmc.facebook.com/intern/diff/D5624371/)
zhaojuanmao
approved these changes
Jan 15, 2020
|
This pull request has been merged in 3d01e3d. |
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#31713 - In case the callbacks are heavy/slow, the other threads should be able to start work on the value of the future after the current thread moves the value and unlock the mutex. - `completed()` is not inlined. Avoid function call overhead. ghstack-source-id: 96694593 Test Plan: tdb Differential Revision: D5624371 fbshipit-source-id: 5762e6e894d20108ec9afedd1a6e64bcd97ee3fe
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Pull Request resolved: pytorch#31713 - In case the callbacks are heavy/slow, the other threads should be able to start work on the value of the future after the current thread moves the value and unlock the mutex. - `completed()` is not inlined. Avoid function call overhead. ghstack-source-id: 96694593 Test Plan: tdb Differential Revision: D5624371 fbshipit-source-id: 5762e6e894d20108ec9afedd1a6e64bcd97ee3fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
completed()is not inlined. Avoid function call overhead.Differential Revision: D5624371