Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example_outputs Doc Edit #31826

Closed
wants to merge 1 commit into from
Closed

example_outputs Doc Edit #31826

wants to merge 1 commit into from

Conversation

Chetank99
Copy link
Contributor

torch.onnx.export docs contain two descriptions for 'example_outputs' arg.
So combined the information for it with the description with the parameters.

torch.onnx.export docs contain two descriptions for 'example_outputs' arg.
So combined the information for it with the description with the parameters.
@kostmo
Copy link
Member

kostmo commented Jan 3, 2020

💊 CircleCI build failures summary and remediations

As of commit c746a53:

  • 1/1 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakage:

See CircleCI build pytorch_linux_xenial_cuda9_cudnn7_py3_slow_test (1/1)

Step: "Test" (full log | pattern match details)

Jan 03 14:38:50 [ FAILED ] JitTest.ADFormulas
Jan 03 14:38:50 [ RUN      ] JitTest.ModuleConversion_CUDA 
Jan 03 14:38:50 [       OK ] JitTest.ModuleConversion_CUDA (0 ms) 
Jan 03 14:38:50 [ RUN      ] JitTest.Interp_CUDA 
Jan 03 14:38:50 [       OK ] JitTest.Interp_CUDA (1 ms) 
Jan 03 14:38:50 [----------] 75 tests from JitTest (3851 ms total) 
Jan 03 14:38:50  
Jan 03 14:38:50 [----------] Global test environment tear-down 
Jan 03 14:38:50 [==========] 75 tests from 1 test case ran. (3851 ms total) 
Jan 03 14:38:50 [  PASSED  ] 74 tests. 
Jan 03 14:38:50 [  FAILED  ] 1 test, listed below: 
Jan 03 14:38:50 [  FAILED  ] JitTest.ADFormulas 
Jan 03 14:38:50  
Jan 03 14:38:50  1 FAILED TEST 
Jan 03 14:38:51 + cleanup 
Jan 03 14:38:51 + retcode=1 
Jan 03 14:38:51 + set +x 
Jan 03 14:38:51 =================== sccache compilation log =================== 
Jan 03 14:38:51 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/tmp/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/tmp/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" } 
Jan 03 14:38:51  
Jan 03 14:38:51 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Jan 03 14:38:51 Compile requests               128 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Chetank99
Copy link
Contributor Author

@zou3519 Hi, the changes got approved but why am I getting one failed check for "ci/circleci: pytorch_linux_xenial_cuda9_cudnn7_py3_slow_test"
Thank you!

@zou3519
Copy link
Contributor

zou3519 commented Jan 3, 2020

@zou3519 Hi, the changes got approved but why am I getting one failed check for "ci/circleci: pytorch_linux_xenial_cuda9_cudnn7_py3_slow_test"
Thank you!

The failure looks unrelated to your documentation changes. If we re-ran it I would expect it to pass.

@Chetank99
Copy link
Contributor Author

@zou3519 Cool! Thanks ^-^/

@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in 3363ca2.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in 3363ca2.

wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary:
torch.onnx.export docs contain two descriptions for 'example_outputs' arg.
So combined the information for it with the description with the parameters.
Pull Request resolved: pytorch#31826

Differential Revision: D19274928

Pulled By: zou3519

fbshipit-source-id: cbcce0a79c51784c1d7aa8981aab8aac118ca9b4
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
Summary:
torch.onnx.export docs contain two descriptions for 'example_outputs' arg.
So combined the information for it with the description with the parameters.
Pull Request resolved: pytorch#31826

Differential Revision: D19274928

Pulled By: zou3519

fbshipit-source-id: cbcce0a79c51784c1d7aa8981aab8aac118ca9b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants