-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'template' keyword warning with clang-cl and clang.exe #32104
Conversation
Summary: Fixes these warnings: ``` xplat\caffe2\caffe2Windows#header-mode-symlink-tree-only,headers\caffe2\operators\quantized\int8_conv_op.h(96,17): warning: use 'template' keyword to treat 'data' as a dependent template name W.t.data<uint8_t>(), ^ template xplat\caffe2\caffe2Windows#header-mode-symlink-tree-only,headers\caffe2\operators\quantized\int8_conv_op.h(97,17): warning: use 'template' keyword to treat 'data' as a dependent template name B.t.data<int32_t>(), ^ template ``` Test Plan: Tested locally with clang-cl and CI for other toolchains Differential Revision: D19353563 fbshipit-source-id: 4676140ed57f83a90a950e481c3c596c9a0ada2b
This pull request was exported from Phabricator. Differential Revision: D19353563 |
💊 CircleCI build failures summary and remediationsAs of commit 55a246b: None of the build failures appear to be your fault.
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 🚧 1 upstream failure recognized by patterns:These builds matched patterns, but were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. |
@kostmo is there some way to rerun? ci/circleci: pytorch_xla_linux_xenial_py3_6_clang7_build. I took a look at https://github.com/pytorch/xla/blob/master/torch_patches/X10-clip_grad.diff and it doesn't look like my change should conflict with it in any way. To rerun the circleci builds, when I hover over "Rerun workflow" it says You need write permission to trigger builds. |
Make sure you're logged in to CircleCI and that your GitHub account is connected to CircleCI. |
I hadn't hit the 'Connect' button to connect CircleCI to GitHub, but I have now and it shows my icon in the top right. I've refreshed a few times, tried both Chrome and Safari. I've also switched between CircleCI's new workflow visualization and the old UX, but it's always grayed out when I try to rerun the job. Anything else to try? |
This pull request has been merged in 7ad0385. |
This pull request has been merged in 7ad0385. |
…2104) Summary: Pull Request resolved: pytorch#32104 Fixes these warnings: ``` xplat\caffe2\caffe2Windows#header-mode-symlink-tree-only,headers\caffe2\operators\quantized\int8_conv_op.h(96,17): warning: use 'template' keyword to treat 'data' as a dependent template name W.t.data<uint8_t>(), ^ template xplat\caffe2\caffe2Windows#header-mode-symlink-tree-only,headers\caffe2\operators\quantized\int8_conv_op.h(97,17): warning: use 'template' keyword to treat 'data' as a dependent template name B.t.data<int32_t>(), ^ template ``` Test Plan: Tested locally with clang-cl and CI for other toolchains Reviewed By: boguscoder Differential Revision: D19353563 fbshipit-source-id: c28afb8c1ad72fd77ef82556ba89fcf09100d1f9
…2104) Summary: Pull Request resolved: pytorch#32104 Fixes these warnings: ``` xplat\caffe2\caffe2Windows#header-mode-symlink-tree-only,headers\caffe2\operators\quantized\int8_conv_op.h(96,17): warning: use 'template' keyword to treat 'data' as a dependent template name W.t.data<uint8_t>(), ^ template xplat\caffe2\caffe2Windows#header-mode-symlink-tree-only,headers\caffe2\operators\quantized\int8_conv_op.h(97,17): warning: use 'template' keyword to treat 'data' as a dependent template name B.t.data<int32_t>(), ^ template ``` Test Plan: Tested locally with clang-cl and CI for other toolchains Reviewed By: boguscoder Differential Revision: D19353563 fbshipit-source-id: c28afb8c1ad72fd77ef82556ba89fcf09100d1f9
Summary:
Fixes these warnings:
Test Plan: Tested locally with clang-cl and CI for other toolchains
Differential Revision: D19353563