Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comment in autograd.h for locking #32222

Closed
wants to merge 1 commit into from

Conversation

albanD
Copy link
Collaborator

@albanD albanD commented Jan 15, 2020

Just update the comment to make it accurate.

@albanD albanD requested a review from apaszke as a code owner January 15, 2020 14:20
@albanD albanD requested a review from ezyang January 15, 2020 14:20
@kostmo
Copy link
Member

kostmo commented Jan 15, 2020

💊 CircleCI build failures summary and remediations

As of commit 10aee40:

None of the build failures appear to be your fault.

  • 2/2 recognized as flaky ❄️
    • Re-run these jobs?

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

❄️ 2 failures recognized as flaky

The following build failures have been detected as flaky and may not be your fault:

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_build (1/2)

Step: "Build" (full log | pattern match details) ❄️

Jan 15 14:49:45 error: failed to execute compile
Jan 15 14:29:35 clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument] 
Jan 15 14:29:35 [ 50%] Building CXX object third_party/onnx/CMakeFiles/onnx.dir/onnx/common/status.cc.o 
Jan 15 14:29:35 clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument] 
Jan 15 14:29:35 [ 50%] Building CXX object third_party/onnx/CMakeFiles/onnx.dir/onnx/common/assertions.cc.o 
Jan 15 14:29:35 clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument] 
Jan 15 14:29:35 [ 50%] Building CXX object third_party/onnx/CMakeFiles/onnx.dir/onnx/common/model_helpers.cc.o 
Jan 15 14:29:35 clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument] 
Jan 15 14:29:35 clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument] 
Jan 15 14:29:35 [ 50%] Linking CXX static library ../../lib/libonnx.a 
Jan 15 14:29:36 [ 50%] Built target onnx 
Jan 15 14:49:45 error: failed to execute compile 
Jan 15 14:49:45 caused by: error reading compile response from server 
Jan 15 14:49:45 caused by: Failed to read response header 
Jan 15 14:49:45 caused by: failed to fill whole buffer 
Jan 15 14:49:45 make[2]: *** [third_party/fbgemm/CMakeFiles/fbgemm_avx2.dir/src/FbgemmI8DepthwiseAvx2.cc.o] Error 2 
Jan 15 14:49:45 make[1]: *** [third_party/fbgemm/CMakeFiles/fbgemm_avx2.dir/all] Error 2 
Jan 15 14:49:45 make: *** [all] Error 2 
Jan 15 14:49:45 third_party/fbgemm/CMakeFiles/fbgemm_avx2.dir/build.make:158: recipe for target 'third_party/fbgemm/CMakeFiles/fbgemm_avx2.dir/src/FbgemmI8DepthwiseAvx2.cc.o' failed 
Jan 15 14:49:45 CMakeFiles/Makefile2:1216: recipe for target 'third_party/fbgemm/CMakeFiles/fbgemm_avx2.dir/all' failed 
Jan 15 14:49:45 Makefile:138: recipe for target 'all' failed 
Jan 15 14:49:45 -- Building version 1.5.0a0+10aee40 

See CircleCI build caffe2_onnx_py3_6_clang7_ubuntu16_04_test (2/2)

Step: "Test" (full log | pattern match details) ❄️

Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_reshape Fatal Python error: Segmentation fault
Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_constant_fold_slice_negative_index PASSED [ 99%] 
Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_constant_fold_transpose PASSED [ 99%] 
Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_constant_fold_transpose_matmul PASSED [ 99%] 
Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_constant_fold_unsqueeze PASSED [ 99%] 
Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_error_on_data_parallel PASSED [ 99%] 
Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_is_in_onnx_export PASSED [ 99%] 
Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_strip_doc_string PASSED [ 99%] 
Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_validate_dynamic_axes_invalid_input_output_name PASSED [ 99%] 
Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_concat PASSED [ 99%] 
Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_lstm PASSED [ 99%] 
Jan 15 15:08:27 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_reshape Fatal Python error: Segmentation fault 
Jan 15 15:08:27  
Jan 15 15:08:27 Current thread 0x00007f8a815b6700 (most recent call first): 
Jan 15 15:08:27   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 43 in repr_instance 
Jan 15 15:08:27   File "/usr/lib/python3.6/reprlib.py", line 65 in repr1 
Jan 15 15:08:27   File "/usr/lib/python3.6/reprlib.py", line 55 in repr 
Jan 15 15:08:27   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 36 in repr 
Jan 15 15:08:27   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 67 in saferepr 
Jan 15 15:08:27   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 655 in repr_args 
Jan 15 15:08:27   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 736 in repr_traceback_entry 
Jan 15 15:08:27   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 777 in repr_traceback 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 1 time.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in ef0f96e.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in ef0f96e.

wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary:
Just update the comment to make it accurate.
Pull Request resolved: pytorch#32222

Differential Revision: D19410428

Pulled By: albanD

fbshipit-source-id: ad13596382613c2728e674a47049ea4f563964b9
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
Summary:
Just update the comment to make it accurate.
Pull Request resolved: pytorch#32222

Differential Revision: D19410428

Pulled By: albanD

fbshipit-source-id: ad13596382613c2728e674a47049ea4f563964b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants