Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[caffe2] Early error throwing for currupted embeddings #32717

Closed
wants to merge 1 commit into from

Conversation

xychang
Copy link

@xychang xychang commented Jan 28, 2020

Differential Revision: D19604954

Differential Revision: D19604954

fbshipit-source-id: 4475f38a299d3a65975a5aaf57747a8a2c3c4b4c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D19604954

@kostmo
Copy link
Member

kostmo commented Jan 28, 2020

💊 CircleCI build failures summary and remediations

As of commit 929a11a:

  • 1/2 broken upstream at merge base 0ea65d6 since Jan 28

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
    git rebase --onto viable/strict $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch origin viable/strict
    git rebase viable/strict
    

    Check out the recency history of this "viable master" tracking branch.

  • 1/2 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakage:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | pattern match details)

Jan 28 12:16:49 RuntimeError: test_autograd failed!
Jan 28 12:16:49 Ran 1046 tests in 285.282s 
Jan 28 12:16:49  
Jan 28 12:16:49 FAILED (errors=1, skipped=13, expected failures=1) 
Jan 28 12:16:49  
Jan 28 12:16:49 Generating XML reports... 
Jan 28 12:16:49 Traceback (most recent call last): 
Jan 28 12:16:49   File "test/run_test.py", line 456, in <module> 
Jan 28 12:16:49     main() 
Jan 28 12:16:49   File "test/run_test.py", line 449, in main 
Jan 28 12:16:49     raise RuntimeError(message) 
Jan 28 12:16:49 RuntimeError: test_autograd failed! 
Jan 28 12:16:49 + cleanup 
Jan 28 12:16:49 + retcode=1 
Jan 28 12:16:49 + set +x 

🚧 1 upstream failure recognized by patterns:

These builds matched patterns, but were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1f78bd0.

wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary: Pull Request resolved: pytorch#32717

Reviewed By: xianjiec

Differential Revision: D19604954

fbshipit-source-id: c02eccf048c0dba3f66d729ab1fda50f3cacef63
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
Summary: Pull Request resolved: pytorch#32717

Reviewed By: xianjiec

Differential Revision: D19604954

fbshipit-source-id: c02eccf048c0dba3f66d729ab1fda50f3cacef63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants