Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Adding dtype argument to the Unary Ops for dtype promotion (testing on expm1 function) #33063

Closed
wants to merge 10 commits into from
Closed

[WIP] Adding dtype argument to the Unary Ops for dtype promotion (testing on expm1 function) #33063

wants to merge 10 commits into from

Commits on Feb 6, 2020

  1. expm1.dtype registered to native_functions.yaml file

    @krshrimali
    krshrimali committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    4e0a6f4 View commit details
    Browse the repository at this point in the history

  2. added dtype argument to expm1 function, changes helper functions as well

    @krshrimali
    krshrimali committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    f6c7f40 View commit details
    Browse the repository at this point in the history

  3. TensorIterator::unary_op now takes promoting argument (default to false)

    @krshrimali
    krshrimali committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    12b09d8 View commit details
    Browse the repository at this point in the history

  4. modified unary_op method of TensorIterator to take promoting argument

    @krshrimali
    krshrimali committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    4d02a27 View commit details
    Browse the repository at this point in the history

  5. typo solved, minor change

    @krshrimali
    krshrimali committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    cbd62fd View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. keyword-only argument for expm1, testing...

    @krshrimali
    krshrimali committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    2e68114 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2020

  1. remove whitespace

    @krshrimali
    krshrimali committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    e5c9584 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. added dtype promotion support for out argument, tested O.K

    @krshrimali
    krshrimali committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    f6a9bd9 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. result.defined() not needed

    @krshrimali
    krshrimali committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    c15367e View commit details
    Browse the repository at this point in the history

  2. ==true not needed, code review

    @krshrimali
    krshrimali committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    7aac2ac View commit details
    Browse the repository at this point in the history