[jit] infer RRef type as container type #33369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add RRef type infer rule when we try to infer a type from a pyobject, this allow script module attributes could contain a rref, (i.e. List[RRefs] as a module attribute) [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
This PR add RRef type infer rule when we try to infer a type from a pyobject, this allow script module attributes could contain a rref, (i.e. List[RRefs] as a module attribute) [ghstack-poisoned]
💊 CircleCI build failures summary and remediationsAs of commit b8cfd65: Commit b8cfd65 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 20 times. |
This PR add RRef type infer rule when we try to infer a type from a pyobject, this allow script module attributes could contain a rref, (i.e. List[RRefs] as a module attribute) Differential Revision: [D19918320](https://our.internmc.facebook.com/intern/diff/D19918320) [ghstack-poisoned]
This PR add RRef type infer rule when we try to infer a type from a pyobject, this allow script module attributes could contain a rref, (i.e. List[RRefs] as a module attribute) Differential Revision: [D19918320](https://our.internmc.facebook.com/intern/diff/D19918320) [ghstack-poisoned]
This PR add RRef type infer rule when we try to infer a type from a pyobject, this allow script module attributes could contain a rref, (i.e. List[RRefs] as a module attribute) Differential Revision: [D19918320](https://our.internmc.facebook.com/intern/diff/D19918320) [ghstack-poisoned]
This PR add RRef type infer rule when we try to infer a type from a pyobject, this allow script module attributes could contain a rref, (i.e. List[RRefs] as a module attribute) Differential Revision: [D19918320](https://our.internmc.facebook.com/intern/diff/D19918320) [ghstack-poisoned]
suo
approved these changes
Feb 26, 2020
hczhu
pushed a commit
that referenced
this pull request
Feb 28, 2020
Summary: Pull Request resolved: #33369 This PR add RRef type infer rule when we try to infer a type from a pyobject, this allow script module attributes could contain a rref, (i.e. List[RRefs] as a module attribute) Test Plan: Imported from OSS Differential Revision: D19918320 Pulled By: wanchaol fbshipit-source-id: e5fd99c0ba5693b22ed48f0c0550b5e1dac89990
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 1, 2020
Summary: Pull Request resolved: #33992 resubmit of #33369 with tweaks on when the rref type being created to ensure ivalue->type() hold the correct RRef type inside of inner element type. Test Plan: Imported from OSS Differential Revision: D20175043 Pulled By: wanchaol fbshipit-source-id: a08b178e989c995632374e6c868d23c5a85526ae
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Pull Request resolved: pytorch#33369 This PR add RRef type infer rule when we try to infer a type from a pyobject, this allow script module attributes could contain a rref, (i.e. List[RRefs] as a module attribute) Test Plan: Imported from OSS Differential Revision: D19918320 Pulled By: wanchaol fbshipit-source-id: e5fd99c0ba5693b22ed48f0c0550b5e1dac89990
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Pull Request resolved: pytorch#33992 resubmit of pytorch#33369 with tweaks on when the rref type being created to ensure ivalue->type() hold the correct RRef type inside of inner element type. Test Plan: Imported from OSS Differential Revision: D20175043 Pulled By: wanchaol fbshipit-source-id: a08b178e989c995632374e6c868d23c5a85526ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR add RRef type infer rule when we try to infer a type from a
pyobject, this allow script module attributes could contain a rref,
(i.e. List[RRefs] as a module attribute)
Differential Revision: D19918320