Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change input value in examples of BCEWithLogitsLoss #34053

Closed
wants to merge 1 commit into from
Closed

Change input value in examples of BCEWithLogitsLoss #34053

wants to merge 1 commit into from

Conversation

nai62
Copy link

@nai62 nai62 commented Mar 2, 2020

In the examples of BCEWithLogitsLoss, 0.999 is passed as the prediction value. The value 0.999 seems to be a probability, but actually it's not. I think it's better to pass a value that is greater than 1, not to confuse readers.

@dr-ci
Copy link

dr-ci bot commented Mar 2, 2020

💊 CircleCI build failures summary and remediations

As of commit a093c3b (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 4/4 broken upstream at merge base a500491 since Mar 02

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
    git rebase --onto viable/strict $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch origin viable/strict
    git rebase viable/strict
    

    Check out the recency history of this "viable master" tracking branch.


🚧 4 upstream failures recognized by patterns:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 2 times.

@ezyang
Copy link
Contributor

ezyang commented Mar 2, 2020

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in a57a7b4.

ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
Summary:
In the examples of `BCEWithLogitsLoss`, `0.999` is passed as the prediction value. The value `0.999` seems to be a probability, but actually it's not. I think it's better to pass a value that is greater than 1, not to confuse readers.
Pull Request resolved: pytorch#34053

Differential Revision: D20195456

Pulled By: ezyang

fbshipit-source-id: 3abbda6232ee1ab141d202d0ce1177526ad59c53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants