Allow std::array as operator argument and return #34399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom ops can now take std::array as arguments and return it. This PR also moves the ops in native_functions.yaml that were blocked by this to now `use_c10_dispatcher: full`. Differential Revision: [D20315072](https://our.internmc.facebook.com/intern/diff/D20315072/) [ghstack-poisoned]
This was referenced Mar 6, 2020
smessmer
added a commit
that referenced
this pull request
Mar 6, 2020
Custom ops can now take std::array as arguments and return it. This PR also moves the ops in native_functions.yaml that were blocked by this to now `use_c10_dispatcher: full`. Differential Revision: [D20315072](https://our.internmc.facebook.com/intern/diff/D20315072/) ghstack-source-id: 99695358 Pull Request resolved: #34399
24 tasks
💊 Build failures summary and remediationsAs of commit a678c12 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 17 times. |
Custom ops can now take std::array as arguments and return it. This PR also moves the ops in native_functions.yaml that were blocked by this to now `use_c10_dispatcher: full`. Differential Revision: [D20315072](https://our.internmc.facebook.com/intern/diff/D20315072/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Mar 10, 2020
Pull Request resolved: #34399 Custom ops can now take std::array as arguments and return it. This PR also moves the ops in native_functions.yaml that were blocked by this to now `use_c10_dispatcher: full`. ghstack-source-id: 99833901 Differential Revision: [D20315072](https://our.internmc.facebook.com/intern/diff/D20315072/)
ezyang
approved these changes
Mar 11, 2020
Custom ops can now take std::array as arguments and return it. This PR also moves the ops in native_functions.yaml that were blocked by this to now `use_c10_dispatcher: full`. Differential Revision: [D20315072](https://our.internmc.facebook.com/intern/diff/D20315072/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Mar 13, 2020
Pull Request resolved: #34399 Custom ops can now take std::array as arguments and return it. This PR also moves the ops in native_functions.yaml that were blocked by this to now `use_c10_dispatcher: full`. ghstack-source-id: 100149868 Differential Revision: [D20315072](https://our.internmc.facebook.com/intern/diff/D20315072/)
Custom ops can now take std::array as arguments and return it. This PR also moves the ops in native_functions.yaml that were blocked by this to now `use_c10_dispatcher: full`. Differential Revision: [D20315072](https://our.internmc.facebook.com/intern/diff/D20315072/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Apr 22, 2020
Pull Request resolved: #34399 Custom ops can now take std::array as arguments and return it. This PR also moves the ops in native_functions.yaml that were blocked by this to now `use_c10_dispatcher: full`. ghstack-source-id: 102643208 Differential Revision: [D20315072](https://our.internmc.facebook.com/intern/diff/D20315072/)
|
This pull request has been merged in deefafb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Custom ops can now take std::array as arguments and return it.
This PR also moves the ops in native_functions.yaml that were blocked by this to now
use_c10_dispatcher: full.Differential Revision: D20315072