Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doxygen for torchbind #35007

Closed
wants to merge 5 commits into from
Closed

Doxygen for torchbind #35007

wants to merge 5 commits into from

Conversation

jamesr66a
Copy link
Collaborator

@jamesr66a jamesr66a commented Mar 19, 2020 •
edited

Stack from ghstack:

image
image
image
image

Differential Revision: D20525680

Doxygen for torchbind
07840a0 
[ghstack-poisoned]
jamesr66a pushed a commit that referenced this pull request Mar 19, 2020
Doxygen for torchbind
c0d8c35 
ghstack-source-id: be3029876c92a4a2b1e006dcf95bc9ea0c3ce1a2
Pull Request resolved: #35007
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 19, 2020
@jamesr66a jamesr66a mentioned this pull request Mar 19, 2020
Closed
dzhulgakov
dzhulgakov approved these changes Mar 19, 2020
View reviewed changes
torch/custom_class.h Outdated Show resolved Hide resolved
torch/custom_class.h Show resolved Hide resolved
jlin27
jlin27 approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@jlin27 jlin27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doxygen build changes LGTM

jamesr66a pushed a commit that referenced this pull request Mar 19, 2020
Doxygen for torchbind
7c7679d 
ghstack-source-id: 0aa227ff130501834bafd22eb30b4acd140e0e3e
Pull Request resolved: #35007
@dr-ci
Copy link

dr-ci bot commented Mar 19, 2020 •
edited

💊 CircleCI build failures summary and remediations

As of commit a5a21b6 (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

  • 1/1 broken upstream at merge base e35dd4f on Mar 18 from 10:10pm to 10:40pm (2 commits; e35dd4f - b2e5e0c)

    Please rebase on the viable/strict branch (expand for instructions)

    Since your merge base is older than viable/strict, run these commands:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

    Check out the recency history of this "viable master" tracking branch.

🚧 1 upstream failure:

These were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

@jamesr66a merged this pull request in 153b16e.

@facebook-github-bot facebook-github-bot deleted the gh/jamesr66a/217/head branch March 22, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlin27 jlin27 jlin27 approved these changes

@dzhulgakov dzhulgakov dzhulgakov approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@ebetica ebetica Awaiting requested review from ebetica

@goldsborough goldsborough Awaiting requested review from goldsborough

@yf225 yf225 Awaiting requested review from yf225

@zdevito zdevito Awaiting requested review from zdevito

@suo suo Awaiting requested review from suo

Assignees
No one assigned
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jamesr66a @facebook-github-bot @jlin27 @dzhulgakov @mruberry