Temporary fix for determinant bug on CPU #35136

vishwakftw · 2020-03-20T23:34:23Z

Changelog:

Make diagonal contiguous

Temporarily Fixes #34061

Changelog: - Make diagonal contiguous

dr-ci · 2020-03-21T00:35:40Z

💊 CI failures summary and remediations

As of commit 0321b5c (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 11 times.

vishwakftw · 2020-07-07T16:41:27Z

@ezyang @gchanan could you please review this PR?

ezyang · 2020-07-07T21:59:53Z

Sure. But can we get a test?

vishwakftw · 2020-07-07T22:03:39Z

Sure, I'll add it, and ping you.

ezyang · 2020-07-10T15:24:14Z

rebase on master to fix the docker problems

…det-bug-cpu

vishwakftw · 2020-07-10T23:18:03Z

ROCM test failure is unrelated. cc: @ezyang

facebook-github-bot

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2020-07-15T06:14:03Z

@ezyang merged this pull request in fcd6d91.

mruberry · 2020-07-15T06:43:01Z

Unlanding. This appears to have broken the slow test build. You can likely reproduce this failure locally by setting PYTORCH_TEST_WITH_SLOW=1 before running test_torch.py. Failing log:

Jul 15 06:19:32 ======================================================================
Jul 15 06:19:32 ERROR [0.018s]: test_det_logdet_slogdet_cpu_float64 (main.TestTorchDeviceTypeCPU)
Jul 15 06:19:32 ----------------------------------------------------------------------
Jul 15 06:19:32 Traceback (most recent call last):
Jul 15 06:19:32 File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 241, in instantiated_test
Jul 15 06:19:32 result = test(self, device_arg, dtype)
Jul 15 06:19:32 File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 463, in wrapper
Jul 15 06:19:32 fn(*args, **kwargs)
Jul 15 06:19:32 File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 411, in dep_fn
Jul 15 06:19:32 return fn(slf, device, *args, **kwargs)
Jul 15 06:19:32 File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 411, in dep_fn
Jul 15 06:19:32 return fn(slf, device, *args, **kwargs)
Jul 15 06:19:32 File "test_torch.py", line 7570, in test_det_logdet_slogdet
Jul 15 06:19:32 test_single_det(q, ref_det, ref_logabsdet, 'orthogonal')
Jul 15 06:19:32 TypeError: test_single_det() takes 3 positional arguments but 4 were given
Jul 15 06:19:32
Jul 15 06:19:32 ======================================================================
Jul 15 06:19:32 ERROR [0.081s]: test_det_logdet_slogdet_cuda_float64 (main.TestTorchDeviceTypeCUDA)
Jul 15 06:19:32 ----------------------------------------------------------------------
Jul 15 06:19:32 Traceback (most recent call last):
Jul 15 06:19:32 File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 777, in wrapper
Jul 15 06:19:32 method(*args, **kwargs)
Jul 15 06:19:32 File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 241, in instantiated_test
Jul 15 06:19:32 result = test(self, device_arg, dtype)
Jul 15 06:19:32 File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 463, in wrapper
Jul 15 06:19:32 fn(*args, **kwargs)
Jul 15 06:19:32 File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 411, in dep_fn
Jul 15 06:19:32 return fn(slf, device, *args, **kwargs)
Jul 15 06:19:32 File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 411, in dep_fn
Jul 15 06:19:32 return fn(slf, device, *args, **kwargs)
Jul 15 06:19:32 File "test_torch.py", line 7570, in test_det_logdet_slogdet
Jul 15 06:19:32 test_single_det(q, ref_det, ref_logabsdet, 'orthogonal')
Jul 15 06:19:32 TypeError: test_single_det() takes 3 positional arguments but 4 were given
Jul 15 06:19:32
Jul 15 06:19:33 ----------------------------------------------------------------------

vishwakftw · 2020-07-15T17:05:18Z

Oh sorry about that, I know where the bug is.

vishwakftw · 2020-07-15T17:05:54Z

@mruberry is there some way to run the slow tests for a PR?

mruberry · 2020-07-15T17:07:30Z

@mruberry is there some way to run the slow tests for a PR?

In the CI you mean? Technically yes but it's laborious. You'd have to add the slow test build to the CI metadata with your PR. This would create a new CircleCI build on the PR. Then you'd have to remove it and resubmit the PR since we wouldn't want to actually commit that CI change. Better to just run it locally, I think.

vishwakftw · 2020-07-15T23:04:20Z

@mruberry this is my test log

PYTORCH_TEST_WITH_SLOW=1 pytest test/test_torch.py -k det_logdet_slogdet -v
================================================ test session starts ================================================
platform linux -- Python 3.7.3, pytest-5.0.1, py-1.8.1, pluggy-0.13.1 -- /home/vishwak/miniconda3/bin/python
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/media/vishwak/Official-1/pytorch/.hypothesis/examples')
rootdir: /media/vishwak/Official-1/pytorch
plugins: hypothesis-4.23.6
collected 5973 items / 5969 deselected / 4 selected                                                                 

test/test_torch.py::TestTorchDeviceTypeCPU::test_det_logdet_slogdet_batched_cpu_float64 PASSED                [ 25%]
test/test_torch.py::TestTorchDeviceTypeCPU::test_det_logdet_slogdet_cpu_float64 PASSED                        [ 50%]
test/test_torch.py::TestTorchDeviceTypeCUDA::test_det_logdet_slogdet_batched_cuda_float64 PASSED              [ 75%]
test/test_torch.py::TestTorchDeviceTypeCUDA::test_det_logdet_slogdet_cuda_float64 PASSED                      [100%]

mruberry · 2020-07-16T00:09:36Z

@ezyang Do you want to reimport or for me to commandeer?

ezyang · 2020-07-16T15:46:22Z

you are always welcome to commandeer oss, no need to ask (but now that I am here, I have reimported)

vishwakftw · 2020-07-21T04:58:24Z

@ezyang could you please reland this PR? Thank you.

facebook-github-bot

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Temporary fix for determinant bug on CPU

9a5318c

Changelog: - Make diagonal contiguous

vishwakftw requested review from colesbury and gchanan March 20, 2020 23:34

pytorchbot added the open source label Mar 20, 2020

albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 24, 2020

Merge branch 'master' into fix-det-bug-cpu

e125c55

Add test

18b810f

ezyang closed this Jul 10, 2020

ezyang reopened this Jul 10, 2020

Merge branch 'master' of https://github.com/pytorch/pytorch into fix-…

a026899

…det-bug-cpu

ezyang approved these changes Jul 13, 2020

View reviewed changes

facebook-github-bot reviewed Jul 13, 2020

View reviewed changes

facebook-github-bot closed this in fcd6d91 Jul 15, 2020

facebook-github-bot added the merged label Jul 15, 2020

vishwakftw reopened this Jul 15, 2020

Fix bug in test_torch.py

0321b5c

vishwakftw requested a review from mruberry July 15, 2020 17:07

facebook-github-bot reviewed Jul 22, 2020

View reviewed changes

facebook-github-bot closed this in 77db932 Jul 23, 2020

vishwakftw deleted the fix-det-bug-cpu branch July 24, 2020 00:52

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Temporary fix for determinant bug on CPU #35136

Temporary fix for determinant bug on CPU #35136

vishwakftw commented Mar 20, 2020

dr-ci bot commented Mar 21, 2020 •

edited

vishwakftw commented Jul 7, 2020

ezyang commented Jul 7, 2020

vishwakftw commented Jul 7, 2020

ezyang commented Jul 10, 2020

vishwakftw commented Jul 10, 2020

facebook-github-bot left a comment

facebook-github-bot commented Jul 15, 2020

mruberry commented Jul 15, 2020

vishwakftw commented Jul 15, 2020

vishwakftw commented Jul 15, 2020

mruberry commented Jul 15, 2020

vishwakftw commented Jul 15, 2020

mruberry commented Jul 16, 2020

ezyang commented Jul 16, 2020

vishwakftw commented Jul 21, 2020

facebook-github-bot left a comment

Temporary fix for determinant bug on CPU #35136

Temporary fix for determinant bug on CPU #35136

Conversation

vishwakftw commented Mar 20, 2020

dr-ci bot commented Mar 21, 2020 • edited

💊 CI failures summary and remediations

vishwakftw commented Jul 7, 2020

ezyang commented Jul 7, 2020

vishwakftw commented Jul 7, 2020

ezyang commented Jul 10, 2020

vishwakftw commented Jul 10, 2020

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Jul 15, 2020

mruberry commented Jul 15, 2020

vishwakftw commented Jul 15, 2020

vishwakftw commented Jul 15, 2020

mruberry commented Jul 15, 2020

vishwakftw commented Jul 15, 2020

mruberry commented Jul 16, 2020

ezyang commented Jul 16, 2020

vishwakftw commented Jul 21, 2020

facebook-github-bot left a comment

Choose a reason for hiding this comment

dr-ci bot commented Mar 21, 2020 •

edited