Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1.5.0] Add TORCH_CUDA_API to FilterDescriptor (#35131) #35406

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

gchanan
Copy link
Contributor

@gchanan gchanan commented Mar 25, 2020

Summary:
FilterDescriptor is missing a TORCH_CUDA_API, so this symbol is not exported from torch_cuda.so, and users could have trouble building cpp_extension when using cudnn.

cc: ptrblck
Pull Request resolved: https://github.com/pytorch/pytorch/pull/35131

Differential Revision: D20604439

Pulled By: ezyang

fbshipit-source-id: c57414fc8a9df9cb1e910e2ec0a48cfdbe7d1779

@gchanan gchanan requested a review from ezyang March 25, 2020 19:52
@gchanan gchanan changed the title Add TORCH_CUDA_API to FilterDescriptor (#35131) [V1.5.0] Add TORCH_CUDA_API to FilterDescriptor (#35131) Mar 25, 2020
@dr-ci
Copy link

dr-ci bot commented Mar 25, 2020

💊 CircleCI build failures summary and remediations

As of commit f007c91 (more details on the Dr. CI page):


  • 3/3 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakages (reran 2 jobs to discount flakiness):

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/2)

Step: "Test" (full log | pattern match details) <confirmed not flaky by 2 failures>

Mar 25 23:57:51 AssertionError: 11 not less than or equal to 1e-05 :
Mar 25 23:57:51 ---------------------------------------------------------------------- 
Mar 25 23:57:51 Traceback (most recent call last): 
Mar 25 23:57:51   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 25 23:57:51     self._join_processes(fn) 
Mar 25 23:57:51   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 25 23:57:51     self._check_return_codes(elapsed_time) 
Mar 25 23:57:51   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 328, in _check_return_codes 
Mar 25 23:57:51     self.assertEqual(first_process.exitcode, 0) 
Mar 25 23:57:51   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 25 23:57:51     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 25 23:57:51 AssertionError: 11 not less than or equal to 1e-05 :  
Mar 25 23:57:51  
Mar 25 23:57:51 ---------------------------------------------------------------------- 
Mar 25 23:57:51 Ran 27 tests in 29.770s 
Mar 25 23:57:51  
Mar 25 23:57:51 FAILED (failures=1) 
Mar 25 23:57:51  
Mar 25 23:57:51 Generating XML reports... 
Mar 25 23:57:51 Traceback (most recent call last): 
Mar 25 23:57:51   File "test/run_test.py", line 674, in <module> 
Mar 25 23:57:51     main() 

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (2/2)

Step: "Test" (full log | pattern match details) <confirmed not flaky by 2 failures>

Mar 26 00:40:29 AssertionError: 11 not less than or equal to 1e-05 :
Mar 26 00:40:29 ---------------------------------------------------------------------- 
Mar 26 00:40:29 Traceback (most recent call last): 
Mar 26 00:40:29   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 26 00:40:29     self._join_processes(fn) 
Mar 26 00:40:29   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 26 00:40:29     self._check_return_codes(elapsed_time) 
Mar 26 00:40:29   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 328, in _check_return_codes 
Mar 26 00:40:29     self.assertEqual(first_process.exitcode, 0) 
Mar 26 00:40:29   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 26 00:40:29     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 26 00:40:29 AssertionError: 11 not less than or equal to 1e-05 :  
Mar 26 00:40:29  
Mar 26 00:40:29 ---------------------------------------------------------------------- 
Mar 26 00:40:29 Ran 27 tests in 22.054s 
Mar 26 00:40:29  
Mar 26 00:40:29 FAILED (failures=1) 
Mar 26 00:40:29  
Mar 26 00:40:29 Generating XML reports... 
Mar 26 00:40:29 Traceback (most recent call last): 
Mar 26 00:40:29   File "test/run_test.py", line 674, in <module> 
Mar 26 00:40:29     main() 

1 job timed out:

  • pytorch_macos_10_13_py3_test

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 9 times.

Summary:
`FilterDescriptor` is missing a `TORCH_CUDA_API`, so this symbol is not exported from `torch_cuda.so`, and users could have trouble building cpp_extension when using cudnn.

cc: ptrblck
Pull Request resolved: pytorch#35131

Differential Revision: D20604439

Pulled By: ezyang

fbshipit-source-id: c57414fc8a9df9cb1e910e2ec0a48cfdbe7d1779
@gchanan gchanan merged commit acb982d into pytorch:release/1.5 Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants