Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5.0] torch.cat: disallow inputs on different devices (#35053) #35407

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

gchanan
Copy link
Contributor

@gchanan gchanan commented Mar 25, 2020

Summary:
Fixes #35045
Pull Request resolved: #35053

Differential Revision: D20545517

Pulled By: ngimel

fbshipit-source-id: eee3fc87c7e578ff44d69d5ce6f92a8f496fa97b

@gchanan gchanan requested a review from ngimel March 25, 2020 19:54
@dr-ci
Copy link

dr-ci bot commented Mar 25, 2020

💊 CircleCI build failures summary and remediations

As of commit 52e658b (more details on the Dr. CI page):


  • 3/3 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakages (reran 2 jobs to discount flakiness):

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/2)

Step: "Test" (full log | pattern match details) <confirmed not flaky by 2 failures>

Mar 25 23:59:24 AssertionError: 11 not less than or equal to 1e-05 :
Mar 25 23:59:24 ---------------------------------------------------------------------- 
Mar 25 23:59:24 Traceback (most recent call last): 
Mar 25 23:59:24   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 25 23:59:24     self._join_processes(fn) 
Mar 25 23:59:24   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 25 23:59:24     self._check_return_codes(elapsed_time) 
Mar 25 23:59:24   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 328, in _check_return_codes 
Mar 25 23:59:24     self.assertEqual(first_process.exitcode, 0) 
Mar 25 23:59:24   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 25 23:59:24     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 25 23:59:24 AssertionError: 11 not less than or equal to 1e-05 :  
Mar 25 23:59:24  
Mar 25 23:59:24 ---------------------------------------------------------------------- 
Mar 25 23:59:24 Ran 27 tests in 29.894s 
Mar 25 23:59:24  
Mar 25 23:59:24 FAILED (failures=1) 
Mar 25 23:59:24  
Mar 25 23:59:24 Generating XML reports... 
Mar 25 23:59:24 Traceback (most recent call last): 
Mar 25 23:59:24   File "test/run_test.py", line 674, in <module> 
Mar 25 23:59:24     main() 

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (2/2)

Step: "Test" (full log | pattern match details) <confirmed not flaky by 2 failures>

Mar 26 00:42:07 AssertionError: 11 not less than or equal to 1e-05 :
Mar 26 00:42:07 ---------------------------------------------------------------------- 
Mar 26 00:42:07 Traceback (most recent call last): 
Mar 26 00:42:07   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 26 00:42:07     self._join_processes(fn) 
Mar 26 00:42:07   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 26 00:42:07     self._check_return_codes(elapsed_time) 
Mar 26 00:42:07   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 328, in _check_return_codes 
Mar 26 00:42:07     self.assertEqual(first_process.exitcode, 0) 
Mar 26 00:42:07   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 26 00:42:07     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 26 00:42:07 AssertionError: 11 not less than or equal to 1e-05 :  
Mar 26 00:42:07  
Mar 26 00:42:07 ---------------------------------------------------------------------- 
Mar 26 00:42:07 Ran 27 tests in 21.032s 
Mar 26 00:42:07  
Mar 26 00:42:07 FAILED (failures=1) 
Mar 26 00:42:07  
Mar 26 00:42:07 Generating XML reports... 
Mar 26 00:42:07 Traceback (most recent call last): 
Mar 26 00:42:07   File "test/run_test.py", line 674, in <module> 
Mar 26 00:42:07     main() 

1 job timed out:

  • pytorch_macos_10_13_py3_test

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 9 times.

Summary:
Fixes pytorch#35045
Pull Request resolved: pytorch#35053

Differential Revision: D20545517

Pulled By: ngimel

fbshipit-source-id: eee3fc87c7e578ff44d69d5ce6f92a8f496fa97b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants