Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.5] PyTorch should always depend on future (#35057) #35412

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

seemethere
Copy link
Member

Cherry pick of #35057

Summary:
Because past is used in caffe2.python.core
Pull Request resolved: #35057

Test Plan: CI

Differential Revision: D20547042

Pulled By: malfet

fbshipit-source-id: cad2123c7b88271fea37f21e616df551075383a8
(cherry picked from commit d3f5045)
Signed-off-by: Eli Uriegas eliuriegas@fb.com

Summary:
Because `past` is used in `caffe2.python.core`
Pull Request resolved: pytorch#35057

Test Plan: CI

Differential Revision: D20547042

Pulled By: malfet

fbshipit-source-id: cad2123c7b88271fea37f21e616df551075383a8
(cherry picked from commit d3f5045)
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere seemethere added this to the 1.5.0 milestone Mar 25, 2020
@dr-ci
Copy link

dr-ci bot commented Mar 25, 2020

💊 CircleCI build failures summary and remediations

As of commit 86cd1ef (more details on the Dr. CI page):


  • 3/3 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakages (reran 2 jobs to discount flakiness):

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/2)

Step: "Test" (full log | pattern match details) <confirmed not flaky by 2 failures>

Mar 25 21:38:26 AssertionError: 12 not less than or equal to 1e-05 :
Mar 25 21:38:26 ---------------------------------------------------------------------- 
Mar 25 21:38:26 Traceback (most recent call last): 
Mar 25 21:38:26   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 25 21:38:26     self._join_processes(fn) 
Mar 25 21:38:26   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 25 21:38:26     self._check_return_codes(elapsed_time) 
Mar 25 21:38:26   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 324, in _check_return_codes 
Mar 25 21:38:26     self.assertEqual(p.exitcode, first_process.exitcode) 
Mar 25 21:38:26   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 25 21:38:26     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 25 21:38:26 AssertionError: 12 not less than or equal to 1e-05 :  
Mar 25 21:38:26  
Mar 25 21:38:26 ---------------------------------------------------------------------- 
Mar 25 21:38:26 Ran 27 tests in 90.432s 
Mar 25 21:38:26  
Mar 25 21:38:26 FAILED (failures=1) 
Mar 25 21:38:26  
Mar 25 21:38:26 Generating XML reports... 
Mar 25 21:38:26 Traceback (most recent call last): 
Mar 25 21:38:26   File "test/run_test.py", line 674, in <module> 
Mar 25 21:38:26     main() 

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (2/2)

Step: "Test" (full log | pattern match details) <confirmed not flaky by 2 failures>

Mar 25 22:14:52 AssertionError: 11 not less than or equal to 1e-05 :
Mar 25 22:14:52 ---------------------------------------------------------------------- 
Mar 25 22:14:52 Traceback (most recent call last): 
Mar 25 22:14:52   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 25 22:14:52     self._join_processes(fn) 
Mar 25 22:14:52   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 25 22:14:52     self._check_return_codes(elapsed_time) 
Mar 25 22:14:52   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 328, in _check_return_codes 
Mar 25 22:14:52     self.assertEqual(first_process.exitcode, 0) 
Mar 25 22:14:52   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 25 22:14:52     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 25 22:14:52 AssertionError: 11 not less than or equal to 1e-05 :  
Mar 25 22:14:52  
Mar 25 22:14:52 ---------------------------------------------------------------------- 
Mar 25 22:14:52 Ran 27 tests in 23.434s 
Mar 25 22:14:52  
Mar 25 22:14:52 FAILED (failures=1) 
Mar 25 22:14:52  
Mar 25 22:14:52 Generating XML reports... 
Mar 25 22:14:52 Traceback (most recent call last): 
Mar 25 22:14:52   File "test/run_test.py", line 674, in <module> 
Mar 25 22:14:52     main() 

1 job timed out:

  • pytorch_macos_10_13_py3_test

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 5 times.

@seemethere seemethere merged commit 3c476a8 into pytorch:release/1.5 Mar 25, 2020
@seemethere seemethere deleted the cherry_pick_35057 branch March 25, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants